third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h - Issue 1855303002: Replace filter outsets with bounds mapping in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h

Issue 1855303002: Replace filter outsets with bounds mapping in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: additional unit tests for FilterOperations::mapRect Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintLayer.h ('K') | « third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterOperations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h b/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h

index 758d67e174df9845ee47ce3e9ddf9bdc95a57a34..19587d3b8ee9a1ef42a943f4b697db52fd0395ef 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterOperations.h

@@ -34,8 +34,6 @@

namespace blink {

-typedef IntRectOutsets FilterOutsets;

class PLATFORM_EXPORT FilterOperations {

DISALLOW_NEW();

public:

@@ -66,8 +64,11 @@ public:

bool canInterpolateWith(const FilterOperations&) const;

- bool hasOutsets() const;

- FilterOutsets outsets() const;

+ // Can map "forward" to determine which pixels in a destination rect are

+ // affected by pixels in the source rect, or "backward" to determine which

+ // pixels in the source rect are required for a destination rect.

+ // See also FilterEffect::mapRect.

+ FloatRect mapRect(const FloatRect&, bool forward) const;

bool hasFilterThatAffectsOpacity() const;

bool hasFilterThatMovesPixels() const;