Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1855303002: Replace filter outsets with bounds mapping in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: additional unit tests for FilterOperations::mapRect Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h
index 2a28fab1e5e6925ffe7f4d3a4fbeb02656f76888..e52d05b8d0478c475d8dd5af1bff8996c44108d8 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h
@@ -326,7 +326,7 @@ public:
PaintLayer* enclosingLayerForPaintInvalidationCrossingFrameBoundaries() const;
- bool hasAncestorWithFilterOutsets() const;
+ bool hasAncestorWithFilterThatMovesPixels() const;
bool canUseConvertToLayerCoords() const
{
@@ -469,8 +469,17 @@ public:
bool paintsWithFilters() const;
bool paintsWithBackdropFilters() const;
FilterEffect* lastFilterEffect() const;
- bool hasFilterOutsets() const;
- FilterOutsets filterOutsets() const;
+
+ // Can map "forward" to determine which pixels in a destination rect are
+ // affected by pixels in the source rect, or "backward" to determine which
+ // pixels in the source rect are required for a destination rect.
+ // See also FilterEffect::mapRect.
+ FloatRect mapRectForFilter(const FloatRect&, bool forward = true) const;
Stephen White 2016/04/06 20:44:11 I couldn't find any callsites that use forward "fa
jbroman 2016/04/06 21:51:41 Alright, done.
+
+ // Calls the above, rounding outwards.
+ LayoutRect mapRectForFilter(const LayoutRect&, bool forward = true) const;
Stephen White 2016/04/06 20:44:11 Naming nit: could we call this one mapLayoutRectFo
jbroman 2016/04/06 21:51:41 Done.
+
+ bool hasFilterThatMovesPixels() const;
PaintLayerFilterInfo* filterInfo() const { return m_rareData ? m_rareData->filterInfo.get() : nullptr; }
PaintLayerFilterInfo& ensureFilterInfo();
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698