LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm - Issue 18553003: Add a runtime flag for distributing extra logical height to rowspans

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm

Issue 18553003: Add a runtime flag for distributing extra logical height to rowspans (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/css/vertical-align-baseline-rowspan-007-expected.html » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm

diff --git a/LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm b/LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm

index facc63f54555e6db97450ae9f8c56e03b4a102ce..07d18b2c79022865a1ea6337cd74ba8b13fc689f 100644

--- a/LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm

+++ b/LayoutTests/fast/css/vertical-align-baseline-rowspan-007.htm

@@ -28,7 +28,7 @@

<!-- The row-spanning cell is the only one with a baseline. It should be baseline-aligned on the first row that it spans

and as it is the same height as the other cells in the row, it sets the baseline for the row. This is unaffected by

the total height of the rowspan (80px) -->

- <p>Test passes if the bottom of first and last black boxes is aligned.</p>

+ <p>Test passes if the bottom of the black boxes is aligned.</p>

<table>

<tr>

<td>