Chromium Code Reviews| Index: ui/ozone/platform/drm/gpu/drm_buffer.cc |
| diff --git a/ui/ozone/platform/drm/gpu/drm_buffer.cc b/ui/ozone/platform/drm/gpu/drm_buffer.cc |
| index bd2e9a9367197412a12a3dead76d452ffc0e1ffa..1c50f1c472416a23393d4f145252baa5294161f5 100644 |
| --- a/ui/ozone/platform/drm/gpu/drm_buffer.cc |
| +++ b/ui/ozone/platform/drm/gpu/drm_buffer.cc |
| @@ -38,8 +38,6 @@ DrmBuffer::DrmBuffer(const scoped_refptr<DrmDevice>& drm) : drm_(drm) { |
| } |
| DrmBuffer::~DrmBuffer() { |
| - surface_.clear(); |
|
f(malita)
2016/04/05 14:31:52
I think we should leave this alone (security/DRM i
tomhudson
2016/04/05 14:52:50
I thought surface_->clear() would be significant,
f(malita)
2016/04/05 14:56:02
You're right - I was thinking this clears the surf
|
| - |
| if (framebuffer_ && !drm_->RemoveFramebuffer(framebuffer_)) |
| PLOG(ERROR) << "DrmBuffer: RemoveFramebuffer: fb " << framebuffer_; |
| @@ -78,8 +76,7 @@ bool DrmBuffer::Initialize(const SkImageInfo& info, |
| } |
| } |
| - surface_ = |
| - skia::AdoptRef(SkSurface::NewRasterDirect(info, mmap_base_, stride_)); |
| + surface_ = SkSurface::MakeRasterDirect(info, mmap_base_, stride_); |
| if (!surface_) { |
| LOG(ERROR) << "DrmBuffer: Failed to create SkSurface: handle " << handle_; |
| return false; |