Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1855223003: Start PowerUsageMonitor unconditionally from UMA bit. (Closed)

Created:
4 years, 8 months ago by gayane -on leave until 09-2017
Modified:
4 years, 8 months ago
Reviewers:
sullivan, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start PowerUsageMonitor unconditionally from UMA bit. As PowerUsageMonitor is only reporting UMA data and nothing else, then PowerUsageMonitor can be started without checking UMA bit. The existing metrics service will take care of not uploading the data if The UMA bit is off. Currently the check is there so that PowerUsageMonitor is not uselessly working in cases when the data will not be uploaded anyway. However in general we prefer to avoid such checks because enabling UMA shouldn't give users 'slower' Chrome. BUG=600398 Committed: https://crrev.com/2d74e1b7211331a5ae569190e5ab7725f47afd0f Cr-Commit-Position: refs/heads/master@{#385183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
gayane -on leave until 09-2017
As discussed by email I am removing the check for UMA bit. Please have a ...
4 years, 8 months ago (2016-04-04 16:05:34 UTC) #3
sullivan
lgtm
4 years, 8 months ago (2016-04-04 17:59:58 UTC) #4
gayane -on leave until 09-2017
+sky for owners review.
4 years, 8 months ago (2016-04-04 18:12:24 UTC) #6
sky
Can you elaborate on why we are doing this? The bug doesn't clarify why either.
4 years, 8 months ago (2016-04-04 20:51:10 UTC) #7
gayane -on leave until 09-2017
On 2016/04/04 20:51:10, sky wrote: > Can you elaborate on why we are doing this? ...
4 years, 8 months ago (2016-04-04 21:07:32 UTC) #9
sky
LGTM
4 years, 8 months ago (2016-04-04 22:47:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855223003/1
4 years, 8 months ago (2016-04-05 14:27:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 16:13:10 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 16:14:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d74e1b7211331a5ae569190e5ab7725f47afd0f
Cr-Commit-Position: refs/heads/master@{#385183}

Powered by Google App Engine
This is Rietveld 408576698