third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h - Issue 1855213002: Add DataPersistent<> for copy-on-modify and use for StyleFilterData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h

Issue 1855213002: Add DataPersistent<> for copy-on-modify and use for StyleFilterData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: indirectly allocate Persistent<> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFilterData.h ('k') | third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h

diff --git a/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h b/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h

index 67c779ba5345280ece74127557a5c42799b06e85..5c720b940b25959ca749242bce37ecb00b72a91e 100644

--- a/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h

+++ b/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h

@@ -31,6 +31,7 @@

#include "core/style/BasicShapes.h"

#include "core/style/CounterDirectives.h"

#include "core/style/CursorData.h"

+#include "core/style/DataPersistent.h"

#include "core/style/DataRef.h"

#include "core/style/FillLayer.h"

#include "core/style/ComputedStyleConstants.h"

@@ -116,8 +117,8 @@ public:

DataRef<StyleTransformData> m_transform; // Transform properties (rotate, scale, skew, etc.)

DataRef<StyleWillChangeData> m_willChange; // CSS Will Change

- DataRef<StyleFilterData> m_filter; // Filter operations (url, sepia, blur, etc.)

- DataRef<StyleFilterData> m_backdropFilter; // Backdrop filter operations (url, sepia, blur, etc.)

+ DataPersistent<StyleFilterData> m_filter; // Filter operations (url, sepia, blur, etc.)

+ DataPersistent<StyleFilterData> m_backdropFilter; // Backdrop filter operations (url, sepia, blur, etc.)

DataRef<StyleGridData> m_grid;

DataRef<StyleGridItemData> m_gridItem;