Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with existing WebRtcEventLogHandler. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index f5646797ab5f86e35d90d8b11ec2aecff41548aa..585b5a6dca163dd4e99a622d18e693dcac56252e 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -143,8 +143,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
#if defined(ENABLE_WEBRTC)
void EnableAudioDebugRecordings(const base::FilePath& file) override;
void DisableAudioDebugRecordings() override;
- void EnableEventLogRecordings(const base::FilePath& file) override;
Henrik Grunell 2016/05/10 08:44:56 Very nice to get rid of these! :)
Ivo-OOO until feb 6 2016/05/12 13:23:24 Agreed :)
- void DisableEventLogRecordings() override;
void SetWebRtcLogMessageCallback(
base::Callback<void(const std::string&)> callback) override;
void ClearWebRtcLogMessageCallback() override;
@@ -341,24 +339,15 @@ class CONTENT_EXPORT RenderProcessHostImpl
#if defined(ENABLE_WEBRTC)
void OnRegisterAecDumpConsumer(int id);
- void OnRegisterEventLogConsumer(int id);
void OnUnregisterAecDumpConsumer(int id);
- void OnUnregisterEventLogConsumer(int id);
void RegisterAecDumpConsumerOnUIThread(int id);
- void RegisterEventLogConsumerOnUIThread(int id);
void UnregisterAecDumpConsumerOnUIThread(int id);
- void UnregisterEventLogConsumerOnUIThread(int id);
void EnableAecDumpForId(const base::FilePath& file, int id);
- void EnableEventLogForId(const base::FilePath& file, int id);
// Sends |file_for_transit| to the render process.
void SendAecDumpFileToRenderer(int id,
IPC::PlatformFileForTransit file_for_transit);
- void SendEventLogFileToRenderer(int id,
- IPC::PlatformFileForTransit file_for_transit);
void SendDisableAecDumpToRenderer();
- void SendDisableEventLogToRenderer();
base::FilePath GetAecDumpFilePathWithExtensions(const base::FilePath& file);
- base::FilePath GetEventLogFilePathWithExtensions(const base::FilePath& file);
#endif
std::unique_ptr<MojoChildConnection> mojo_child_connection_;

Powered by Google App Engine
This is Rietveld 408576698