content/renderer/media/rtc_peer_connection_handler.cc - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added CONTENT_EXPORT to WebRTCEventLogHost. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/rtc_peer_connection_handler.h ('k') | content/renderer/media/webrtc/peer_connection_dependency_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_peer_connection_handler.cc

diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc

index 361948cde063a1c9bba884e2f733fecf44d9d6a8..fcf1b822cc5437a7a8b5c9feea4baeef1042bd75 100644

--- a/content/renderer/media/rtc_peer_connection_handler.cc

+++ b/content/renderer/media/rtc_peer_connection_handler.cc

@@ -1437,6 +1437,19 @@ void RTCPeerConnectionHandler::CloseClientPeerConnection() {

client_->closePeerConnection();

}

+void RTCPeerConnectionHandler::StartEventLog(IPC::PlatformFileForTransit file,

+ int64_t max_file_size_bytes) {

+ DCHECK(thread_checker_.CalledOnValidThread());

+ DCHECK(file != IPC::InvalidPlatformFileForTransit());

+ native_peer_connection_->StartRtcEventLog(

+ IPC::PlatformFileForTransitToPlatformFile(file), max_file_size_bytes);

+void RTCPeerConnectionHandler::StopEventLog() {

+ DCHECK(thread_checker_.CalledOnValidThread());

+ native_peer_connection_->StopRtcEventLog();

blink::WebRTCDataChannelHandler* RTCPeerConnectionHandler::createDataChannel(

const blink::WebString& label, const blink::WebRTCDataChannelInit& init) {

DCHECK(thread_checker_.CalledOnValidThread());