content/browser/media/webrtc/webrtc_internals_message_handler.cc - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc/webrtc_internals_message_handler.cc

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Henrik and enabled logging for newly created render processes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/webrtc/webrtc_internals.cc ('K') | « content/browser/media/webrtc/webrtc_internals.cc ('k') | content/browser/renderer_host/media/peer_connection_tracker_host.h » ('j') | content/browser/resources/media/dump_creator.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc/webrtc_internals_message_handler.cc

diff --git a/content/browser/media/webrtc/webrtc_internals_message_handler.cc b/content/browser/media/webrtc/webrtc_internals_message_handler.cc

index eaaea95a73da8d4513942fbd79af71dece83f50a..ea74c5bb4eca30dc2b3128187ee24fc3e1a4ec1c 100644

--- a/content/browser/media/webrtc/webrtc_internals_message_handler.cc

+++ b/content/browser/media/webrtc/webrtc_internals_message_handler.cc

@@ -94,8 +94,12 @@ void WebRTCInternalsMessageHandler::OnSetAudioDebugRecordingsEnabled(

void WebRTCInternalsMessageHandler::OnSetEventLogRecordingsEnabled(

bool enable,

const base::ListValue* /* unused_list */) {

- WebRTCInternals::GetInstance()->SetEventLogRecordings(

- enable, enable ? web_ui()->GetWebContents() : nullptr);

+ if (enable) {

+ WebRTCInternals::GetInstance()->EnableEventLogRecordings(

+ web_ui()->GetWebContents());

+ } else {

+ WebRTCInternals::GetInstance()->DisableEventLogRecordings();

+ }

}

void WebRTCInternalsMessageHandler::OnDOMLoadDone(