content/browser/media/webrtc/webrtc_internals.h - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc/webrtc_internals.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Henrik and enabled logging for newly created render processes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/webrtc/webrtc_eventlog_host.cc ('K') | « content/browser/media/webrtc/webrtc_eventlog_host.cc ('k') | content/browser/media/webrtc/webrtc_internals.cc » ('j') | content/browser/media/webrtc/webrtc_internals.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc/webrtc_internals.h

diff --git a/content/browser/media/webrtc/webrtc_internals.h b/content/browser/media/webrtc/webrtc_internals.h

index e319313df2db8a47b130ca3404f173da82b5f6e1..bf4f8e942f2aedc95224e667e37fe046e2f3fc3b 100644

--- a/content/browser/media/webrtc/webrtc_internals.h

+++ b/content/browser/media/webrtc/webrtc_internals.h

@@ -99,10 +99,11 @@ class CONTENT_EXPORT WebRTCInternals : public RenderProcessHostObserver,

const base::FilePath& GetAudioDebugRecordingsFilePath() const;

// Enables or disables diagnostic event log.

- void SetEventLogRecordings(bool enable, content::WebContents* web_contents);

+ void EnableEventLogRecordings(content::WebContents* web_contents);

+ void DisableEventLogRecordings();

bool IsEventLogRecordingsEnabled() const;

- const base::FilePath& GetEventLogRecordingsFilePath() const;

+ const base::FilePath& GetEventLogFilePath() const;

protected:

// Constructor/Destructor are protected to allow tests to derive from the