Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: content/browser/renderer_host/media/peer_connection_tracker_host.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small bugfix and Tommi's comment. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/peer_connection_tracker_host.h
diff --git a/content/browser/renderer_host/media/peer_connection_tracker_host.h b/content/browser/renderer_host/media/peer_connection_tracker_host.h
index 53a96302e04bf3b7c52d2de792ada290a6d82267..53926f87c8191f2d1b879ac62c5a3b6b1f9ba45f 100644
--- a/content/browser/renderer_host/media/peer_connection_tracker_host.h
+++ b/content/browser/renderer_host/media/peer_connection_tracker_host.h
@@ -19,6 +19,8 @@ class ListValue;
namespace content {
+class WebRTCEventLogHost;
+
// This class is the host for PeerConnectionTracker in the browser process
// managed by RenderProcessHostImpl. It receives PeerConnection events from
// PeerConnectionTracker as IPC messages that it forwards to WebRTCInternals.
@@ -26,7 +28,8 @@ namespace content {
class PeerConnectionTrackerHost : public BrowserMessageFilter,
public base::PowerObserver {
public:
- explicit PeerConnectionTrackerHost(int render_process_id);
+ PeerConnectionTrackerHost(int render_process_id,
+ WebRTCEventLogHost* event_log_host);
// content::BrowserMessageFilter override.
bool OnMessageReceived(const IPC::Message& message) override;
@@ -57,6 +60,8 @@ class PeerConnectionTrackerHost : public BrowserMessageFilter,
int render_process_id_;
+ WebRTCEventLogHost* const event_log_host_;
Henrik Grunell 2016/06/01 08:31:11 Is the event log host guaranteed to outlive the PC
Ivo-OOO until feb 6 2016/06/02 14:43:39 Both are members of RenderProcessHostImpl, so they
Henrik Grunell 2016/06/03 07:40:52 OK, then one will be deleted before the other, so
Ivo-OOO until feb 6 2016/06/03 16:07:01 Actually, I don't think that the order matters in
+
DISALLOW_COPY_AND_ASSIGN(PeerConnectionTrackerHost);
};

Powered by Google App Engine
This is Rietveld 408576698