content/renderer/media/rtc_peer_connection_handler.h - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments by ncarter and grunell. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/peer_connection_tracker.cc ('K') | « content/renderer/media/peer_connection_tracker.cc ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_peer_connection_handler.h

diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h

index 7fe3bf259b77d91bd11fa21990c4a0f641990303..7fd83d0a963fa86104942327ae06964bb4f7f4fe 100644

--- a/content/renderer/media/rtc_peer_connection_handler.h

+++ b/content/renderer/media/rtc_peer_connection_handler.h

@@ -20,6 +20,7 @@

#include "base/threading/thread_checker.h"

#include "content/common/content_export.h"

#include "content/renderer/media/webrtc/media_stream_track_metrics.h"

+#include "ipc/ipc_platform_file.h"

#include "third_party/WebKit/public/platform/WebMediaStreamSource.h"

#include "third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h"

#include "third_party/WebKit/public/platform/WebRTCStatsRequest.h"

@@ -166,6 +167,12 @@ class CONTENT_EXPORT RTCPeerConnectionHandler

// Tells the |client_| to close RTCPeerConnection.

void CloseClientPeerConnection();

+ // Start recording an event log.

+ void StartEventLog(IPC::PlatformFileForTransit file,

+ int64_t max_file_size_bytes);

+ // Stop recording an event log.

+ void StopEventLog();

protected:

webrtc::PeerConnectionInterface* native_peer_connection() {

return native_peer_connection_.get();