Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3758)

Unified Diff: chrome/browser/media/webrtc_event_log_handler.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments by ncarter and grunell. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_event_log_handler.h
diff --git a/chrome/browser/media/webrtc_event_log_handler.h b/chrome/browser/media/webrtc_event_log_handler.h
index 33eaa5cf1a1263304f4e88d9936932e22732be65..6bed72a0762f91e86db3805011ffc3893cb5287a 100644
--- a/chrome/browser/media/webrtc_event_log_handler.h
+++ b/chrome/browser/media/webrtc_event_log_handler.h
@@ -8,6 +8,7 @@
#include <stddef.h>
#include <stdint.h>
+#include <set>
#include <string>
#include "base/callback.h"
@@ -36,8 +37,9 @@ class WebRtcEventLogHandler
explicit WebRtcEventLogHandler(Profile* profile);
- // Starts an RTC event log. The call writes the most recent events to a
- // file and then starts logging events for the given |delay|.
+ // Starts an RTC event log for each peerconnection on the specified |host|.
+ // The call writes the most recent events to a file and then starts logging
+ // events for the given |delay|.
// If |delay| is zero, the logging will continue until
// StopWebRtcEventLogging()
// is explicitly invoked.
@@ -81,9 +83,6 @@ class WebRtcEventLogHandler
// The profile associated with our renderer process.
Profile* const profile_;
- // Must be accessed on the UI thread.
- bool is_rtc_event_logging_in_progress_;
-
// This counter allows saving each log in a separate file.
uint64_t current_rtc_event_log_id_;
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_event_log_handler.cc » ('j') | content/browser/media/webrtc/webrtc_eventlog_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698