Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: content/public/browser/render_process_host.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved event log related bookkeeping/IPC from chrome/ to content/, into new class called WebRTCEvent… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index 74ac574d5439830d30b2b7dfca5f4e46fa8dbb06..cdd5762e160f21de7cbaf4ce6c79ed8b79893715 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -219,9 +219,6 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
virtual void EnableAudioDebugRecordings(const base::FilePath& file) = 0;
virtual void DisableAudioDebugRecordings() = 0;
- virtual void EnableEventLogRecordings(const base::FilePath& file) = 0;
- virtual void DisableEventLogRecordings() = 0;
-
// When set, |callback| receives log messages regarding, for example, media
// devices (webcams, mics, etc) that were initially requested in the render
// process associated with this RenderProcessHost.
@@ -244,6 +241,16 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
bool incoming,
bool outgoing,
const WebRtcRtpPacketCallback& packet_callback) = 0;
+
+ // Starts a WebRTC event log for each peerconnection on the render process.
+ // A base file_path can be supplied, which will be extended to include several
+ // identifiers to ensure uniqueness. If a recording was already in progress,
+ // this call will return false and have no other effect.
+ virtual bool StartWebRTCEventLog(const base::FilePath& file_path) = 0;
ncarter (slow) 2016/05/20 18:27:21 This looks basically like a rename of the old func
Ivo-OOO until feb 6 2016/05/25 14:57:00 Good idea, done.
+
+ // Stops recording a WebRTC event log for each peerconnection on the render
+ // process. If no recording was in progress, this call will return false.
+ virtual bool StopWebRTCEventLog() = 0;
#endif
// Tells the ResourceDispatcherHost to resume a deferred navigation without

Powered by Google App Engine
This is Rietveld 408576698