content/common/media/peer_connection_tracker_messages.h - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Side by Side Diff: content/common/media/peer_connection_tracker_messages.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with existing WebRtcEventLogHandler. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/resources/media/dump_creator.js ('K') | « content/common/media/aec_dump_messages.h ('k') | content/public/browser/render_process_host.h » ('j') | content/renderer/media/peer_connection_tracker.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/values.h"	5 #include "base/values.h"

6 #include "content/common/content_export.h"	6 #include "content/common/content_export.h"

7 #include "ipc/ipc_message_macros.h"	7 #include "ipc/ipc_message_macros.h"

	8 #include "ipc/ipc_platform_file.h"

8	9

9 #undef IPC_MESSAGE_EXPORT	10 #undef IPC_MESSAGE_EXPORT

10 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT	11 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

11 #define IPC_MESSAGE_START PeerConnectionTrackerMsgStart	12 #define IPC_MESSAGE_START PeerConnectionTrackerMsgStart

12	13

13 IPC_STRUCT_BEGIN(PeerConnectionInfo)	14 IPC_STRUCT_BEGIN(PeerConnectionInfo)

14 IPC_STRUCT_MEMBER(int, lid)	15 IPC_STRUCT_MEMBER(int, lid)

15 IPC_STRUCT_MEMBER(std::string, rtc_configuration)	16 IPC_STRUCT_MEMBER(std::string, rtc_configuration)

16 IPC_STRUCT_MEMBER(std::string, constraints)	17 IPC_STRUCT_MEMBER(std::string, constraints)

17 IPC_STRUCT_MEMBER(std::string, url)	18 IPC_STRUCT_MEMBER(std::string, url)

(...skipping 16 matching lines...) Expand all Loading...
34 bool /audio/,	35 bool /audio/,

35 bool /video/,	36 bool /video/,

36 // The constraints strings are for dispaly only and should	37 // The constraints strings are for dispaly only and should

37 // not be parsed by the browser for security reasons.	38 // not be parsed by the browser for security reasons.

38 std::string /* audio_constraints */,	39 std::string /* audio_constraints */,

39 std::string /* video_constraints */)	40 std::string /* video_constraints */)

40	41

41 // Messages sent to PeerConnectionTracker.	42 // Messages sent to PeerConnectionTracker.

42 IPC_MESSAGE_CONTROL0(PeerConnectionTracker_GetAllStats)	43 IPC_MESSAGE_CONTROL0(PeerConnectionTracker_GetAllStats)

43 IPC_MESSAGE_CONTROL0(PeerConnectionTracker_OnSuspend)	44 IPC_MESSAGE_CONTROL0(PeerConnectionTracker_OnSuspend)

	45 IPC_MESSAGE_CONTROL3(PeerConnectionTracker_StartEventLog,

	46 int /* lid */,

	47 IPC::PlatformFileForTransit /* file */,

	48 int64_t /* max_file_size_bytes */)
	dcheng 2016/05/10 06:48:17 Why not unsigned? Why not unsigned? Ivo-OOO until feb 6 2016/05/12 13:23:24 This value represents a file size on disk. Althoug Show quoted text On 2016/05/10 06:48:17, dcheng wrote: > Why not unsigned? This value represents a file size on disk. Although we currently don't have plans to use really large log files, they could conceivably become larger than 2GB at some point in the future (if we log more data than we currently do for a very long call). Also, on the WebRTC API, this value will be passed as an int64_t, so I think it makes sense to use the same type internally as well.
	49 IPC_MESSAGE_CONTROL1(PeerConnectionTracker_StopEventLog, int /* lid */)

OLD	NEW