Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: content/browser/resources/media/dump_creator.js

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with existing WebRtcEventLogHandler. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * Provides the UI for dump creation. 7 * Provides the UI for dump creation.
8 */ 8 */
9 var DumpCreator = (function() { 9 var DumpCreator = (function() {
10 /** 10 /**
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 ' each time or move the produced files before enabling again.</p>' + 55 ' each time or move the produced files before enabling again.</p>' +
56 '<p><label><input type=checkbox>' + 56 '<p><label><input type=checkbox>' +
57 'Enable diagnostic packet and event recording</label></p>' + 57 'Enable diagnostic packet and event recording</label></p>' +
58 '<p class=audio-recordings-info>A diagnostic packet and event' + 58 '<p class=audio-recordings-info>A diagnostic packet and event' +
59 ' recording can be used for analyzing various issues related to' + 59 ' recording can be used for analyzing various issues related to' +
60 ' thread starvation, jitter buffers or bandwidth estimation. Two' + 60 ' thread starvation, jitter buffers or bandwidth estimation. Two' +
61 ' types of data are logged. First, incoming and outgoing RTP headers' + 61 ' types of data are logged. First, incoming and outgoing RTP headers' +
62 ' and RTCP packets are logged. These do not include any audio or' + 62 ' and RTCP packets are logged. These do not include any audio or' +
63 ' video information, nor any other types of personally identifiable' + 63 ' video information, nor any other types of personally identifiable' +
64 ' information (so no IP addresses or URLs). Checking this box will' + 64 ' information (so no IP addresses or URLs). Checking this box will' +
65 ' enable the recording for currently ongoing WebRTC calls. When' + 65 ' enable the recording for ongoing WebRTC calls and for future' +
66 ' the box is unchecked or this page is closed, all active recordings' + 66 ' WebRTC calls. When the box is unchecked or this page is closed,' +
67 ' will be stopped. Recording in multiple tabs or multiple recordings' + 67 ' all ongoing recordings will be stopped and this recording' +
68 ' in the same tab is currently not supported. When enabling, a' + 68 ' functionality will be disabled for future WebRTC calls. Recording' +
69 ' filename for the recording can be selected. If an existing file is' + 69 ' in multiple tabs or multiple recordings in the same tab will cause' +
70 ' selected, it will be overwritten. </p>'; 70 ' multiple log files to be created. When enabling, a filename for the' +
Henrik Grunell 2016/05/10 08:44:56 If you select a filename and multiple files are cr
Ivo-OOO until feb 6 2016/05/12 13:23:24 Good idea, done.
71 ' recording can be selected. If an existing file is selected, it' +
72 ' will be overwritten. </p>';
71 content.getElementsByTagName('a')[0].addEventListener( 73 content.getElementsByTagName('a')[0].addEventListener(
72 'click', this.onDownloadData_.bind(this)); 74 'click', this.onDownloadData_.bind(this));
73 content.getElementsByTagName('input')[0].addEventListener( 75 content.getElementsByTagName('input')[0].addEventListener(
74 'click', this.onAudioDebugRecordingsChanged_.bind(this)); 76 'click', this.onAudioDebugRecordingsChanged_.bind(this));
75 content.getElementsByTagName('input')[1].addEventListener( 77 content.getElementsByTagName('input')[1].addEventListener(
76 'click', this.onEventLogRecordingsChanged_.bind(this)); 78 'click', this.onEventLogRecordingsChanged_.bind(this));
77 } 79 }
78 80
79 DumpCreator.prototype = { 81 DumpCreator.prototype = {
80 // Mark the diagnostic audio recording checkbox checked. 82 // Mark the diagnostic audio recording checkbox checked.
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 var enabled = this.root_.getElementsByTagName('input')[1].checked; 143 var enabled = this.root_.getElementsByTagName('input')[1].checked;
142 if (enabled) { 144 if (enabled) {
143 chrome.send('enableEventLogRecordings'); 145 chrome.send('enableEventLogRecordings');
144 } else { 146 } else {
145 chrome.send('disableEventLogRecordings'); 147 chrome.send('disableEventLogRecordings');
146 } 148 }
147 }, 149 },
148 }; 150 };
149 return DumpCreator; 151 return DumpCreator;
150 })(); 152 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698