Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/media/webrtc_event_log_handler.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unittest for adding more PeerConnections than the maximum limit. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_EVENT_LOG_HANDLER_H_ 5 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_EVENT_LOG_HANDLER_H_
6 #define CHROME_BROWSER_MEDIA_WEBRTC_EVENT_LOG_HANDLER_H_ 6 #define CHROME_BROWSER_MEDIA_WEBRTC_EVENT_LOG_HANDLER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 18 matching lines...) Expand all
29 typedef base::Callback<void(bool, const std::string&)> GenericDoneCallback; 29 typedef base::Callback<void(bool, const std::string&)> GenericDoneCallback;
30 typedef base::Callback<void(const std::string&)> RecordingErrorCallback; 30 typedef base::Callback<void(const std::string&)> RecordingErrorCallback;
31 typedef base::Callback<void(const std::string&, bool, bool)> 31 typedef base::Callback<void(const std::string&, bool, bool)>
32 RecordingDoneCallback; 32 RecordingDoneCallback;
33 33
34 // Key used to attach the handler to the RenderProcessHost. 34 // Key used to attach the handler to the RenderProcessHost.
35 static const char kWebRtcEventLogHandlerKey[]; 35 static const char kWebRtcEventLogHandlerKey[];
36 36
37 explicit WebRtcEventLogHandler(Profile* profile); 37 explicit WebRtcEventLogHandler(Profile* profile);
38 38
39 // Starts an RTC event log. The call writes the most recent events to a 39 // Starts an RTC event log for each peerconnection on the specified |host|.
40 // file and then starts logging events for the given |delay|. 40 // The call writes the most recent events to a file and then starts logging
41 // events for the given |delay|.
41 // If |delay| is zero, the logging will continue until 42 // If |delay| is zero, the logging will continue until
42 // StopWebRtcEventLogging() 43 // StopWebRtcEventLogging()
43 // is explicitly invoked. 44 // is explicitly invoked.
44 // |callback| is invoked once recording stops. If |delay| is zero 45 // |callback| is invoked once recording stops. If |delay| is zero
45 // |callback| is invoked once recording starts. 46 // |callback| is invoked once recording starts.
46 // If a recording was already in progress, |error_callback| is invoked instead 47 // If a recording was already in progress, |error_callback| is invoked instead
47 // of |callback|. 48 // of |callback|.
48 void StartWebRtcEventLogging(content::RenderProcessHost* host, 49 void StartWebRtcEventLogging(content::RenderProcessHost* host,
49 base::TimeDelta delay, 50 base::TimeDelta delay,
50 const RecordingDoneCallback& callback, 51 const RecordingDoneCallback& callback,
(...skipping 23 matching lines...) Expand all
74 void DoStopWebRtcEventLogging(content::RenderProcessHost* host, 75 void DoStopWebRtcEventLogging(content::RenderProcessHost* host,
75 bool is_manual_stop, 76 bool is_manual_stop,
76 uint64_t audio_debug_recordings_id, 77 uint64_t audio_debug_recordings_id,
77 const RecordingDoneCallback& callback, 78 const RecordingDoneCallback& callback,
78 const RecordingErrorCallback& error_callback, 79 const RecordingErrorCallback& error_callback,
79 const base::FilePath& log_directory); 80 const base::FilePath& log_directory);
80 81
81 // The profile associated with our renderer process. 82 // The profile associated with our renderer process.
82 Profile* const profile_; 83 Profile* const profile_;
83 84
84 // Must be accessed on the UI thread.
85 bool is_rtc_event_logging_in_progress_;
86
87 // This counter allows saving each log in a separate file. 85 // This counter allows saving each log in a separate file.
88 uint64_t current_rtc_event_log_id_; 86 uint64_t current_rtc_event_log_id_;
89 87
90 base::ThreadChecker thread_checker_; 88 base::ThreadChecker thread_checker_;
91 DISALLOW_COPY_AND_ASSIGN(WebRtcEventLogHandler); 89 DISALLOW_COPY_AND_ASSIGN(WebRtcEventLogHandler);
92 }; 90 };
93 91
94 #endif // CHROME_BROWSER_MEDIA_WEBRTC_EVENT_LOG_HANDLER_H_ 92 #endif // CHROME_BROWSER_MEDIA_WEBRTC_EVENT_LOG_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/media/webrtc_event_log_handler.cc » ('j') | content/browser/media/webrtc/webrtc_eventlog_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698