Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

content/browser/media/webrtc/webrtc_eventlog_host.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_WEBRTC_WEBRTC_EVENTLOG_HOST_H_
+#define CONTENT_BROWSER_MEDIA_WEBRTC_WEBRTC_EVENTLOG_HOST_H_
+
+#include <vector>
+
+#include "base/files/file_path.h"
+
+namespace content {
+
+// This class is used to active and disable WebRTC event logs on each of the

[Henrik Grunell, 2016/06/01 08:31:11]

Nit: "enable and disable"?

[Ivo-OOO until feb 6, 2016/06/02 14:43:38]

Done.

+// peer connections in the render process. To be able to do this, it needs to

[Henrik Grunell, 2016/06/01 08:31:11]

Nit: "PeerConnections". Also, a bit of repetition in this comment.

[Ivo-OOO until feb 6, 2016/06/02 14:43:38]

Good point. I think the second part is not that useful so I removed it.

+// keep track of all the PeerConnections in the render process.
+class WebRTCEventLogHost {
+ public:
+  explicit WebRTCEventLogHost(int render_process_id);
+  ~WebRTCEventLogHost();
+
+  // Starts an RTC event log for each peerconnection on the render process.

[Henrik Grunell, 2016/06/01 08:31:11]

Nit: "PeerConnection".

[Ivo-OOO until feb 6, 2016/06/02 14:43:38]

Done.

+  // A base file_path can be supplied, which will be extended to include several
+  // identifiers to ensure uniqueness. If a recording was already in progress,
+  // this call will return false and have no other effect. Should be called
+  // from the Browser UI thread.

[Henrik Grunell, 2016/06/01 08:31:11]

You should comment that it will start logging for all new PeerConnections added
after starting.

[Ivo-OOO until feb 6, 2016/06/02 14:43:38]

I added a remark a few lines above.

+  bool StartWebRTCEventLog(const base::FilePath& file_path);
+
+  // Stops recording an RTC event log for each peerconnection on the render
+  // process. If no recording was in progress, this call will return false.
+  bool StopWebRTCEventLog();
+
+  // This function should be used to notify the WebRTCEventLogHost object that a
+  // PeerConnection was created in the corresponding render process.
+  void PeerConnectionAdded(int peer_connection_local_id);
+
+  // This function should be used to notify the WebRTCEventLogHost object that a
+  // PeerConnection was removed in the corresponding render process.
+  void PeerConnectionRemoved(int peer_connection_local_id);
+
+ private:
+  // The render process ID that this object is associated with.
+  const int render_process_id_;
+
+  // In case new PeerConnections are created during logging, the path is needed
+  // to enable logging for them.
+  base::FilePath base_file_path_;
+
+  // The local identifiers of all the currently active PeerConnections.
+  std::vector<int> active_peer_connection_local_id_;

[Henrik Grunell, 2016/06/01 08:31:11]

Nit: ..._ids_? (plural)

[Ivo-OOO until feb 6, 2016/06/02 14:43:38]

Done.

+
+  // Number of active log files that have been opened. Since this class is only
+  // accessed from the Browser UI thread, it is safe to access this from every

[Henrik Grunell, 2016/06/01 08:31:11]

Nit: You could comment in the class description that this class lives on the UI
thread, and all function must be called on it. Then remove thread comments on
functions and variables.

[Ivo-OOO until feb 6, 2016/06/02 14:43:38]

Good idea.

+  // instance of the class.
+  static int number_active_log_files_;
+
+  // Track if the RTC event log is currently active.
+  bool rtc_event_logging_enabled_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebRTCEventLogHost);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_MEDIA_WEBRTC_WEBRTC_EVENTLOG_HOST_H_