Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

content/browser/media/webrtc/webrtc_eventlog_host.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_WEBRTC_WEBRTC_EVENTLOG_HOST_H_
+#define CONTENT_BROWSER_MEDIA_WEBRTC_WEBRTC_EVENTLOG_HOST_H_
+
+#include <set>
+
+#include "base/files/file_path.h"
+#include "base/threading/thread_checker.h"
+
+namespace content {
+
+// This class is used to active and disable WebRTC event logs on each of the
+// peer connections in the render process. To be able to do this, it needs to
+// keep track of all the PeerConnections in the render process.
+class WebRTCEventLogHost {
+ public:
+  explicit WebRTCEventLogHost(int render_process_id);
+  ~WebRTCEventLogHost();
+
+  // Starts an RTC event log for each peerconnection on the render process.
+  // A base file_path can be supplied, which will be extended to include several
+  // identifiers to ensure uniqueness. If a recording was already in progress,
+  // this call will return false and have no other effect.
+  bool StartWebRTCEventLog(const base::FilePath& file_path);
+
+  // Stops recording an RTC event log for each peerconnection on the render
+  // process. If no recording was in progress, this call will return false.
+  bool StopWebRTCEventLog();
+
+  void PeerConnectionAdded(int connection_id);

[Henrik Grunell, 2016/05/24 13:31:59]

Please comment on these functions too.

[Ivo-OOO until feb 6, 2016/05/25 14:57:00]

Done.

+  void PeerConnectionRemoved(int connection_id);
+
+ private:
+  // The render process ID that this object is associated with.
+  const int render_process_id_;
+
+  // In case new PeerConnections are created during logging, the path is needed
+  // to enable logging for them.
+  base::FilePath base_file_path_;
+
+  // The local identifiers of all the currently active PeerConnections.
+  std::set<int> active_peer_connection_local_id_;
+
+  // Number of active log files that have been opened.
+  int number_active_log_files_;

[Henrik Grunell, 2016/05/24 13:31:59]

Can active_peer_connection_local_id_.size() be used instead of this variable?

[Ivo-OOO until feb 6, 2016/05/25 14:57:00]

That's an interesting question. Theoretically it could happen that a single
peerconnection gets repeatedly created and then destroyed. In that scenario,
active_peer_connection_local_id_.size() would only be zero or one, but many
files would be created. I'm not sure if that's something we should try to
prevent, what do you think?

+
+  bool is_rtc_event_logging_in_progress_;
+
+  base::ThreadChecker thread_checker_;
+};

[Henrik Grunell, 2016/05/24 13:31:59]

DISALLOW_COPY_AND_ASSIGN()

[Ivo-OOO until feb 6, 2016/05/25 14:57:00]

Done.

+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_MEDIA_WEBRTC_WEBRTC_EVENTLOG_HOST_H_