Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: content/browser/resources/media/dump_creator.js

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Introduced WebRTCCallbackInterface. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * Provides the UI for dump creation. 7 * Provides the UI for dump creation.
8 */ 8 */
9 var DumpCreator = (function() { 9 var DumpCreator = (function() {
10 /** 10 /**
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 '.aec_dump.&lt;recording ID&gt;</div>' + 48 '.aec_dump.&lt;recording ID&gt;</div>' +
49 '<div>&lt;base filename&gt;.&lt;render process ID&gt;' + 49 '<div>&lt;base filename&gt;.&lt;render process ID&gt;' +
50 '.source_input.&lt;stream ID&gt;.wav</div></p>' + 50 '.source_input.&lt;stream ID&gt;.wav</div></p>' +
51 '<p class=audio-recordings-info>If recordings are disabled and then' + 51 '<p class=audio-recordings-info>If recordings are disabled and then' +
52 ' enabled using the same base filename, the microphone recording file' + 52 ' enabled using the same base filename, the microphone recording file' +
53 ' will be overwritten, and the AEC dump file will be appended to and' + 53 ' will be overwritten, and the AEC dump file will be appended to and' +
54 ' may become invalid. It is recommended to choose a new base filename' + 54 ' may become invalid. It is recommended to choose a new base filename' +
55 ' each time or move the produced files before enabling again.</p>' + 55 ' each time or move the produced files before enabling again.</p>' +
56 '<p><label><input type=checkbox>' + 56 '<p><label><input type=checkbox>' +
57 'Enable diagnostic packet and event recording</label></p>' + 57 'Enable diagnostic packet and event recording</label></p>' +
58 '<p class=audio-recordings-info>A diagnostic packet and event' + 58 '<p class=audio-recordings-info>A diagnostic packet and event' +
Henrik Grunell 2016/05/13 09:05:31 Nit: The class name "audio-recordings-info" isn't
Ivo-OOO until feb 6 2016/05/18 16:26:55 Done.
59 ' recording can be used for analyzing various issues related to' + 59 ' recording can be used for analyzing various issues related to' +
60 ' thread starvation, jitter buffers or bandwidth estimation. Two' + 60 ' thread starvation, jitter buffers or bandwidth estimation. Two' +
61 ' types of data are logged. First, incoming and outgoing RTP headers' + 61 ' types of data are logged. First, incoming and outgoing RTP headers' +
62 ' and RTCP packets are logged. These do not include any audio or' + 62 ' and RTCP packets are logged. These do not include any audio or' +
63 ' video information, nor any other types of personally identifiable' + 63 ' video information, nor any other types of personally identifiable' +
64 ' information (so no IP addresses or URLs). Checking this box will' + 64 ' information (so no IP addresses or URLs). Checking this box will' +
65 ' enable the recording for currently ongoing WebRTC calls. When' + 65 ' enable the recording for ongoing WebRTC calls and for future' +
66 ' the box is unchecked or this page is closed, all active recordings' + 66 ' WebRTC calls. When the box is unchecked or this page is closed,' +
67 ' will be stopped. Recording in multiple tabs or multiple recordings' + 67 ' all ongoing recordings will be stopped and this recording' +
68 ' in the same tab is currently not supported. When enabling, a' + 68 ' functionality will be disabled for future WebRTC calls. Recording' +
69 ' filename for the recording can be selected. If an existing file is' + 69 ' in multiple tabs or multiple recordings in the same tab will cause' +
70 ' selected, it will be overwritten. </p>'; 70 ' multiple log files to be created. When enabling, a filename for the' +
71 ' recording can be selected. The entered filename is used as a' +
Henrik Grunell 2016/05/13 09:05:31 Nit: "entered" -> "selected".
Ivo-OOO until feb 6 2016/05/18 16:26:54 Done.
72 ' base, to which the following suffixes will be appended.</p>' +
73 ' <p><div>&lt;base filename&gt;.&lt;render process ID&gt;' +
Henrik Grunell 2016/05/13 09:05:31 Nit: No need for <div></div> since there's only on
Ivo-OOO until feb 6 2016/05/18 16:26:55 Done.
74 '.&lt;recording ID&gt;</div></p>' +
75 '<p class=audio-recordings-info>Event logs from different tabs will' +
Henrik Grunell 2016/05/13 09:05:31 This is not always true; different tabs can share
Ivo-OOO until feb 6 2016/05/18 16:26:55 I did not know that. I think removing this part wo
76 ' have a different render process ID, and recordings from multiple' +
77 ' peerconnections within the same tab will have a different recording' +
Henrik Grunell 2016/05/13 09:05:31 Nit: PeerConnections
Henrik Grunell 2016/05/13 09:05:31 "...will have different recording IDs."
Ivo-OOO until feb 6 2016/05/18 16:26:55 This text is removed now.
78 ' ID. If a file with the same name already exists, it will be' +
79 ' overwritten. </p>';
71 content.getElementsByTagName('a')[0].addEventListener( 80 content.getElementsByTagName('a')[0].addEventListener(
72 'click', this.onDownloadData_.bind(this)); 81 'click', this.onDownloadData_.bind(this));
73 content.getElementsByTagName('input')[0].addEventListener( 82 content.getElementsByTagName('input')[0].addEventListener(
74 'click', this.onAudioDebugRecordingsChanged_.bind(this)); 83 'click', this.onAudioDebugRecordingsChanged_.bind(this));
75 content.getElementsByTagName('input')[1].addEventListener( 84 content.getElementsByTagName('input')[1].addEventListener(
76 'click', this.onEventLogRecordingsChanged_.bind(this)); 85 'click', this.onEventLogRecordingsChanged_.bind(this));
77 } 86 }
78 87
79 DumpCreator.prototype = { 88 DumpCreator.prototype = {
80 // Mark the diagnostic audio recording checkbox checked. 89 // Mark the diagnostic audio recording checkbox checked.
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 var enabled = this.root_.getElementsByTagName('input')[1].checked; 150 var enabled = this.root_.getElementsByTagName('input')[1].checked;
142 if (enabled) { 151 if (enabled) {
143 chrome.send('enableEventLogRecordings'); 152 chrome.send('enableEventLogRecordings');
144 } else { 153 } else {
145 chrome.send('disableEventLogRecordings'); 154 chrome.send('disableEventLogRecordings');
146 } 155 }
147 }, 156 },
148 }; 157 };
149 return DumpCreator; 158 return DumpCreator;
150 })(); 159 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698