Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1855133003: Fix service isolate shutdown for precompilation. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix service isolate shutdown for precompilation. Release and debug precompilation VMs start the service isolate, but do not wait for it to startup (it is there to support Observatory and not for loading). The main isolate can finish and the VM begin to shutdown before the service isolate runs main. Handle this case. BUG=http://dartbug.com/26144 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/321872ed73a2a350d02e485540f3309a687ce88d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M runtime/vm/service_isolate.cc View 7 chunks +28 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 8 months ago (2016-04-04 16:20:53 UTC) #2
Cutch
lgtm
4 years, 8 months ago (2016-04-04 16:24:22 UTC) #4
rmacnak
4 years, 8 months ago (2016-04-04 16:27:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
321872ed73a2a350d02e485540f3309a687ce88d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698