Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1855133002: convert //courgette to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
Reviewers:
huangs
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert //courgette to std::unique_ptr BUG=554298 Committed: https://crrev.com/1007a4af51fee305fd95933d9bdcd83c89f9df29 Cr-Commit-Position: refs/heads/master@{#386511}

Patch Set 1 #

Patch Set 2 : rebase on master #

Patch Set 3 : update comment in memory_allocator.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -88 lines) Patch
M courgette/adjustment_method_unittest.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M courgette/assembly_program.h View 5 chunks +5 lines, -5 lines 0 comments Download
M courgette/assembly_program.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M courgette/courgette_tool.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M courgette/disassembler_elf_32_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M courgette/disassembler_elf_32_x86.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M courgette/disassembler_elf_32_x86_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M courgette/disassembler_win32_x64_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M courgette/disassembler_win32_x86_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M courgette/encode_decode_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M courgette/encoded_program.h View 2 chunks +2 lines, -2 lines 0 comments Download
M courgette/encoded_program.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M courgette/encoded_program_fuzz_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M courgette/encoded_program_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M courgette/memory_allocator.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M courgette/patch_generator_x86_32.h View 5 chunks +6 lines, -5 lines 0 comments Download
M courgette/patcher_x86_32.h View 3 chunks +5 lines, -4 lines 0 comments Download
M courgette/program_detector.h View 2 chunks +4 lines, -3 lines 0 comments Download
M courgette/program_detector.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M courgette/third_party/bsdiff_create.cc View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/third_party/qsufsort_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855133002/1
4 years, 8 months ago (2016-04-03 19:56:26 UTC) #2
Mostyn Bramley-Moore
@huangs: please take a look.
4 years, 8 months ago (2016-04-03 20:30:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 21:07:21 UTC) #6
huangs
Sorry, missed this completely! Could you sync and merge, since there have been updates last ...
4 years, 8 months ago (2016-04-11 14:25:54 UTC) #7
huangs
NIT: Please also update memory_allocator.h, which mentions scoped_ptr in comment. disassembler_elf_32.* also uses ScopedVector. Would ...
4 years, 8 months ago (2016-04-11 14:40:42 UTC) #8
Mostyn Bramley-Moore
> NIT: Please also update memory_allocator.h, which mentions scoped_ptr in > comment. Thanks for the ...
4 years, 8 months ago (2016-04-11 20:11:10 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855133002/40001
4 years, 8 months ago (2016-04-11 20:11:16 UTC) #11
huangs
LGTM. Thanks!
4 years, 8 months ago (2016-04-11 20:55:29 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 21:58:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855133002/40001
4 years, 8 months ago (2016-04-11 23:10:13 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-11 23:18:20 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 23:20:25 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1007a4af51fee305fd95933d9bdcd83c89f9df29
Cr-Commit-Position: refs/heads/master@{#386511}

Powered by Google App Engine
This is Rietveld 408576698