Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1855023002: [turbofan] New Register Allocator Validator (Closed)

Created:
4 years, 8 months ago by Mircea Trofin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

The previous validator had trouble handling cases where the move optimizer was merging phi lowering moves into the node defining the phi. Addressing such cases proved to be too difficult in the existing validator. The new validator addresses this, by making no assumptions on phi lowering details. This unblocks 1824303002. BUG= Committed: https://crrev.com/48f0597dd41f2edd6ab654b9ac05dabce0a3797e Cr-Commit-Position: refs/heads/master@{#35557}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -466 lines) Patch
M src/compiler/register-allocator-verifier.h View 1 2 3 4 5 6 7 8 3 chunks +173 lines, -3 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 2 3 4 5 6 7 7 chunks +240 lines, -463 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Mircea Trofin
4 years, 8 months ago (2016-04-15 19:46:56 UTC) #3
Benedikt Meurer
LGTM. Thanks. https://codereview.chromium.org/1855023002/diff/140001/src/compiler/register-allocator-verifier.h File src/compiler/register-allocator-verifier.h (right): https://codereview.chromium.org/1855023002/diff/140001/src/compiler/register-allocator-verifier.h#newcode206 src/compiler/register-allocator-verifier.h:206: auto exists = map_.find(op); Nit: s/exists/it/
4 years, 8 months ago (2016-04-18 04:22:12 UTC) #5
Mircea Trofin
https://codereview.chromium.org/1855023002/diff/140001/src/compiler/register-allocator-verifier.h File src/compiler/register-allocator-verifier.h (right): https://codereview.chromium.org/1855023002/diff/140001/src/compiler/register-allocator-verifier.h#newcode206 src/compiler/register-allocator-verifier.h:206: auto exists = map_.find(op); On 2016/04/18 04:22:12, Benedikt Meurer ...
4 years, 8 months ago (2016-04-18 04:38:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855023002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855023002/160001
4 years, 8 months ago (2016-04-18 04:38:39 UTC) #9
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 8 months ago (2016-04-18 05:03:38 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 05:05:02 UTC) #13
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/48f0597dd41f2edd6ab654b9ac05dabce0a3797e
Cr-Commit-Position: refs/heads/master@{#35557}

Powered by Google App Engine
This is Rietveld 408576698