Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 18550002: Add trampoline to enable pointer -> handle code calls (Closed)

Created:
7 years, 5 months ago by danno
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add trampoline to enable pointer -> handle code calls R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15507

Patch Set 1 #

Patch Set 2 : Reduce patch #

Patch Set 3 : Add comment #

Total comments: 6

Patch Set 4 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M src/factory.h View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
M src/heap.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/18550002/diff/5001/src/factory.h File src/factory.h (right): https://codereview.chromium.org/18550002/diff/5001/src/factory.h#newcode572 src/factory.h:572: class IdempotentHandleToPointerCodeTrampoline { nit: s/HandleToPointer/PointerToHandle/ https://codereview.chromium.org/18550002/diff/5001/src/factory.h#newcode579 ...
7 years, 5 months ago (2013-07-05 07:49:07 UTC) #1
danno
Review feedback addressed, landing https://codereview.chromium.org/18550002/diff/5001/src/factory.h File src/factory.h (right): https://codereview.chromium.org/18550002/diff/5001/src/factory.h#newcode572 src/factory.h:572: class IdempotentHandleToPointerCodeTrampoline { On 2013/07/05 ...
7 years, 5 months ago (2013-07-05 09:35:54 UTC) #2
danno
7 years, 5 months ago (2013-07-05 09:36:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r15507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698