[Extensions] Add more bindings access checks

[Extensions] Add more bindings access checks

BUG=598165
Committed: https://crrev.com/14ff9d0cded8ae8032ef027d1f33c6666a695019
Cr-Commit-Position: refs/heads/master@{#385282}

[Devlin, 2016-04-04 17:26:58]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-04-05 00:15:33]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-04-05 00:16:13]

Description was changed from

==========
test

BUG=
==========

to

==========
[Extensions] Add more bindings access checks

BUG=598165
==========

[Devlin, 2016-04-05 00:17:32]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-04-05 00:17:33]

Antony, another one for you.

https://codereview.chromium.org/1854983002/diff/40001/chrome/renderer/extensi...
File chrome/renderer/extensions/file_browser_handler_custom_bindings.cc (left):

https://codereview.chromium.org/1854983002/diff/40001/chrome/renderer/extensi...
chrome/renderer/extensions/file_browser_handler_custom_bindings.cc:26:
RouteFunction("GetEntryURL",
This was only used in fileManagerPrivate bindings, so it's been moved there.

[asargent_no_longer_on_chrome, 2016-04-05 17:38:28]

lgtm

BTW, are we going to deprecate the version of RouteFunction that doesn't take
|feature_name|? Or is it still safe to use for some purposes? If we're going to
keep it, it might make sense to add a comment explaining which one developers
should pick for different situations.

[Devlin, 2016-04-05 17:46:16]

On 2016/04/05 17:38:28, Antony Sargent wrote:
> lgtm
> 
> BTW, are we going to deprecate the version of RouteFunction that doesn't take
> |feature_name|? Or is it still safe to use for some purposes? If we're going
to
> keep it, it might make sense to add a comment explaining which one developers
> should pick for different situations.

Good call.  I think we should deprecate the other RouteFunction().  There have
been enough bindings bugs that I think the extra check will be worth it in all
cases - it's pretty cheap.  I've added a comment and a TODO to remove the old
version.

[Devlin, 2016-04-05 20:51:13]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-04-05 20:51:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1854983002/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2016-04-05 20:51:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854983002/60001

[commit-bot: I haz the power, 2016-04-05 20:57:06]

Description was changed from

==========
[Extensions] Add more bindings access checks

BUG=598165
==========

to

==========
[Extensions] Add more bindings access checks

BUG=598165
==========

[commit-bot: I haz the power, 2016-04-05 20:57:07]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-04-05 20:59:22]

Description was changed from

==========
[Extensions] Add more bindings access checks

BUG=598165
==========

to

==========
[Extensions] Add more bindings access checks

BUG=598165

Committed: https://crrev.com/14ff9d0cded8ae8032ef027d1f33c6666a695019
Cr-Commit-Position: refs/heads/master@{#385282}
==========

[commit-bot: I haz the power, 2016-04-05 20:59:23]

Patchset 2 (id:??) landed as
https://crrev.com/14ff9d0cded8ae8032ef027d1f33c6666a695019
Cr-Commit-Position: refs/heads/master@{#385282}