Plumb GpuSwapBuffers completion from Mus GPU thread to WS thread

Plumb GpuSwapBuffers completion from Mus GPU thread to WS thread

Add the necessary code to plumb the SwapBuffersAsync completion indication from
Mus GPU thread back to the invoking WS thread.

BUG=596549
Committed: https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca
Cr-Commit-Position: refs/heads/master@{#384760}

[rjkroege, 2016-04-01 23:18:57]

rjkroege@chromium.org changed reviewers:
+ fsamuel@chromium.org

[rjkroege, 2016-04-01 23:18:57]

PTAL

[Fady Samuel, 2016-04-01 23:24:42]

LGTM + nits.

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/comman...
File components/mus/gles2/command_buffer_driver.cc (right):

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/comman...
components/mus/gles2/command_buffer_driver.cc:89:
scoped_refptr<GLSurfaceAdapterMus> s =
nit: better variable name than s please?

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/gl_sur...
File components/mus/gles2/gl_surface_adapter.h (right):

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/gl_sur...
components/mus/gles2/gl_surface_adapter.h:19: // Wraps a GLSurface using
gfx::GLSurfaceAdapter.
nit: Better class level comments please. I'm not very familiar with
GLSurfaceAdapter so getting a high level description of the responsibilities of
this class would be super useful for future reference.

[rjkroege, 2016-04-01 23:58:45]

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/comman...
File components/mus/gles2/command_buffer_driver.cc (right):

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/comman...
components/mus/gles2/command_buffer_driver.cc:89:
scoped_refptr<GLSurfaceAdapterMus> s =
On 2016/04/01 23:24:42, Fady Samuel wrote:
> nit: better variable name than s please?

Done. I may have been corrupted by viewing the plan9 source. :-)

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/gl_sur...
File components/mus/gles2/gl_surface_adapter.h (right):

https://codereview.chromium.org/1854953002/diff/1/components/mus/gles2/gl_sur...
components/mus/gles2/gl_surface_adapter.h:19: // Wraps a GLSurface using
gfx::GLSurfaceAdapter.
On 2016/04/01 23:24:42, Fady Samuel wrote:
> nit: Better class level comments please. I'm not very familiar with
> GLSurfaceAdapter so getting a high level description of the responsibilities
of
> this class would be super useful for future reference.

Done.

[rjkroege, 2016-04-01 23:58:52]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-04-01 23:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1854953002/#ps20001
(title: "review nits")

[commit-bot: I haz the power, 2016-04-01 23:59:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854953002/20001

[commit-bot: I haz the power, 2016-04-02 00:47:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-02 00:48:26]

Description was changed from

==========
Plumb GpuSwapBuffers completion from Mus GPU thread to WS thread

Add the necessary code to plumb the SwapBuffersAsync completion indication from
Mus GPU thread back to the invoking WS thread.

BUG=596549
==========

to

==========
Plumb GpuSwapBuffers completion from Mus GPU thread to WS thread

Add the necessary code to plumb the SwapBuffersAsync completion indication from
Mus GPU thread back to the invoking WS thread.

BUG=596549

Committed: https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca
Cr-Commit-Position: refs/heads/master@{#384760}
==========

[commit-bot: I haz the power, 2016-04-02 00:48:27]

Patchset 2 (id:??) landed as
https://crrev.com/224cf40b93b5bde158e61610e8fd233ab5f776ca
Cr-Commit-Position: refs/heads/master@{#384760}

[brucedawson, 2016-04-12 00:40:35]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-04-12 00:40:36]

https://codereview.chromium.org/1854953002/diff/20001/components/mus/gles2/co...
File components/mus/gles2/command_buffer_driver.cc (right):

https://codereview.chromium.org/1854953002/diff/20001/components/mus/gles2/co...
components/mus/gles2/command_buffer_driver.cc:85: static
scoped_refptr<gfx::GLSurface> underlying_surface;
What is this line for? underlying_surface is never used in this change.

In the subsequent change:
https://codereview.chromium.org/1857243005/diff/80001/components/mus/gles2/co...
then underlying_surface is used, but it is also redeclared so that the static
local continues to be unnecessary. Delete?

This was found by VC++'s /analyze, crbug.com/427616.

[rjkroege, 2016-04-12 01:27:29]

On 2016/04/12 00:40:36, brucedawson wrote:
>
https://codereview.chromium.org/1854953002/diff/20001/components/mus/gles2/co...
> File components/mus/gles2/command_buffer_driver.cc (right):
> 
>
https://codereview.chromium.org/1854953002/diff/20001/components/mus/gles2/co...
> components/mus/gles2/command_buffer_driver.cc:85: static
> scoped_refptr<gfx::GLSurface> underlying_surface;
> What is this line for? underlying_surface is never used in this change.
> 
> In the subsequent change:
>
https://codereview.chromium.org/1857243005/diff/80001/components/mus/gles2/co...
> then underlying_surface is used, but it is also redeclared so that the static
> local continues to be unnecessary. Delete?
> 
> This was found by VC++'s /analyze, crbug.com/427616.

Thanks for finding my bad rebase. Fixed:
https://codereview.chromium.org/1875303003/