Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: content/shell/browser/shell_browser_main_parts.cc

Issue 1854933002: [Android] Initialize CrashDumpManager earlier in ContentShell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell_browser_main_parts.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_browser_main_parts.cc
diff --git a/content/shell/browser/shell_browser_main_parts.cc b/content/shell/browser/shell_browser_main_parts.cc
index 9b17cd58040a09ad74ba1528ea318e995e140ca1..1c5dcb56cf38b629311ca6c164f74ca87839f2b7 100644
--- a/content/shell/browser/shell_browser_main_parts.cc
+++ b/content/shell/browser/shell_browser_main_parts.cc
@@ -146,8 +146,8 @@ void ShellBrowserMainParts::InitializeMessageLoopContext() {
gfx::Size());
}
-void ShellBrowserMainParts::PreMainMessageLoopRun() {
#if defined(OS_ANDROID)
+int ShellBrowserMainParts::PreCreateThreads() {
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableCrashReporter)) {
base::FilePath crash_dumps_dir =
@@ -155,8 +155,12 @@ void ShellBrowserMainParts::PreMainMessageLoopRun() {
switches::kCrashDumpsDir);
crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dumps_dir));
}
+
+ return 0;
+}
#endif
+void ShellBrowserMainParts::PreMainMessageLoopRun() {
net_log_.reset(new ShellNetLog("content_shell"));
InitializeBrowserContexts();
Shell::Initialize();
« no previous file with comments | « content/shell/browser/shell_browser_main_parts.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698