Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1854933002: [Android] Initialize CrashDumpManager earlier in ContentShell. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Initialize CrashDumpManager earlier in ContentShell. BUG=598132 Committed: https://crrev.com/e834612b9e99125f7e49523559f856953cdf01ea Cr-Commit-Position: refs/heads/master@{#384815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/shell/browser/shell_browser_main_parts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jbudorick
This is basically https://codereview.chromium.org/889083002/ ported to the content shell.
4 years, 8 months ago (2016-04-01 22:28:03 UTC) #2
Lei Zhang
lgtm, but you still need OWNERS
4 years, 8 months ago (2016-04-01 22:38:16 UTC) #3
jbudorick
+peter for //content/browser OWNERS
4 years, 8 months ago (2016-04-01 22:45:15 UTC) #5
Peter Beverloo
lgtm
4 years, 8 months ago (2016-04-02 14:49:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854933002/1
4 years, 8 months ago (2016-04-02 22:01:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 22:36:54 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 22:38:36 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e834612b9e99125f7e49523559f856953cdf01ea
Cr-Commit-Position: refs/heads/master@{#384815}

Powered by Google App Engine
This is Rietveld 408576698