Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 18549: When the server says "nosniff" but then doesn't give us a Content-Type we now... (Closed)

Created:
10 years, 7 months ago by abarth-chromium
Modified:
8 years, 2 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

When the server says "nosniff" but then doesn't give us a Content-Type we now treat the response as "text/plain". Before, we treated the response as a download. This behavior is (a) safer and (b) matches what we expect in IE8. R=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8559

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 2 chunks +10 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
I'm not sure how to write a test for this. How can a ui_test tell ...
10 years, 7 months ago (2009-01-23 05:57:37 UTC) #1
darin (slow to review)
10 years, 6 months ago (2009-01-23 15:59:05 UTC) #2
LGTM

http://codereview.chromium.org/18549/diff/4/202
File chrome/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/18549/diff/4/202#newcode120
Line 120: LowerCaseEqualsASCII(content_type_options, "nosniff");
good fix

Powered by Google App Engine
This is Rietveld 408576698