pkg/analyzer/lib/src/summary/summary_sdk.dart - Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summary_sdk.dart

Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix for a review comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/summary/summary_sdk.dart

diff --git a/pkg/analyzer/lib/src/summary/summary_sdk.dart b/pkg/analyzer/lib/src/summary/summary_sdk.dart

index 6ebb3f466ad84b00833bd9de73e6c722872e1830..68d0a0c7d84c120313cd8590c9adc1997165773c 100644

--- a/pkg/analyzer/lib/src/summary/summary_sdk.dart

+++ b/pkg/analyzer/lib/src/summary/summary_sdk.dart

@@ -94,14 +94,14 @@ class SdkSummaryResultProvider implements SummaryResultProvider {

return false;

}

if (result == CREATED_RESOLVED_UNIT1 ||

- result == CREATED_RESOLVED_UNIT2 ||

Brian Wilkerson 2016/04/01 20:12:53 Not sure why this isn't still part of the list.

result == CREATED_RESOLVED_UNIT3 ||

result == CREATED_RESOLVED_UNIT4 ||

result == CREATED_RESOLVED_UNIT5 ||

result == CREATED_RESOLVED_UNIT6 ||

result == CREATED_RESOLVED_UNIT7 ||

result == CREATED_RESOLVED_UNIT8 ||

- result == CREATED_RESOLVED_UNIT9) {

+ result == CREATED_RESOLVED_UNIT9 ||

+ result == CREATED_RESOLVED_UNIT10) {

entry.setValue(result, true, TargetedResult.EMPTY_LIST);

return true;

}

« no previous file with comments | « pkg/analyzer/lib/src/plugin/engine_plugin.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »