Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1854793003: AST-based type inference clean-up (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

AST-based type inference clean-up This CL simplifies the type hierarchy used in AST summarization. There was no need for TypeParameterizedElementForLink and TypeParameterizedContext to be separate classes, since every class that mixed in the former also implemented the latter, and vice versa. Also, it re-enables two tests that were made to pass by previous CLs. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2932f3ebdb224f14b8fca204ccc13bfcc83cf1ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -37 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 11 chunks +16 lines, -27 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-01 17:48:58 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-01 18:02:33 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-01 18:18:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2932f3ebdb224f14b8fca204ccc13bfcc83cf1ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698