Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

TBR=jorgelo
BUG=589318
Committed: https://crrev.com/66605a610bce190e818ebfc73913a126c025ffb3
Cr-Commit-Position: refs/heads/master@{#384658}

[agrieve, 2016-04-01 14:34:15]

Created Reland of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use
test()

[agrieve, 2016-04-01 14:35:23]

Description was changed from

==========
Reland of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test()
(patchset #1 id:1 of https://codereview.chromium.org/1848033005/ )

Reason for revert:
fixing

Original issue's description:
> Revert of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test()
(patchset #8 id:140001 of https://codereview.chromium.org/1841193002/ )
> 
> Reason for revert:
> breaks both suites on GN, e.g.
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester
> 
> Original issue's description:
> > GN: Make breakpad_unittests & sandbox_linux_unittests use test()
> >
> > This simplifies build rules for native tests, and allows us to get rid
> > of ${target}_deps targets (once recipes are updated).
> >
> > This change fixes the generated wrapper scripts, which didn't work.
> >
> > BUG=589318
> >
> > Committed: https://crrev.com/638c8c12c9cd5086d4ba8704852cb1167e7b4ae9
> > Cr-Commit-Position: refs/heads/master@{#384348}
> 
>
TBR=mark@chromium.org,dpranke@chromium.org,jorgelo@chromium.org,agrieve@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=589318
> 
> Committed: https://crrev.com/cb514fa85364e415c7ce4f6a8365e78a00fe7dfb
> Cr-Commit-Position: refs/heads/master@{#384571}

TBR=mark@chromium.org,dpranke@chromium.org,jorgelo@chromium.org,jbudorick@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589318
==========

to

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

BUG=589318
==========

[agrieve, 2016-04-01 14:55:24]

On 2016/04/01 14:34:15, agrieve wrote:
> Created Reland of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use
> test()

Diff is a bit noisy, but only change since last time is in test.gni

[jbudorick, 2016-04-01 14:59:58]

lgtm

https://codereview.chromium.org/1854733003/diff/200001/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/1854733003/diff/200001/testing/test.gni#newco...
testing/test.gni:46: # TODO(agrieve): This is required for component builds, but
it's not
Is this TODO still accurate?

[Mark Mentovai, 2016-04-01 15:27:16]

LGTM restamp

[Dirk Pranke, 2016-04-01 16:51:49]

lgtm stamp

[agrieve, 2016-04-01 16:52:37]

https://codereview.chromium.org/1854733003/diff/200001/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/1854733003/diff/200001/testing/test.gni#newco...
testing/test.gni:46: # TODO(agrieve): This is required for component builds, but
it's not
On 2016/04/01 14:59:58, jbudorick wrote:
> Is this TODO still accurate?

It is. We should change it so the entire directory is pushed rather than just
the executable. (and also set an LDPATH when running it).

[agrieve, 2016-04-01 16:53:19]

Description was changed from

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

BUG=589318
==========

to

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

TBR=jorgelo
BUG=589318
==========

[agrieve, 2016-04-01 16:53:22]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-01 16:53:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854733003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854733003/200001

[commit-bot: I haz the power, 2016-04-01 19:19:10]

Description was changed from

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

TBR=jorgelo
BUG=589318
==========

to

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

TBR=jorgelo
BUG=589318
==========

[commit-bot: I haz the power, 2016-04-01 19:19:11]

Committed patchset #2 (id:200001)

[commit-bot: I haz the power, 2016-04-01 19:20:17]

Description was changed from

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

TBR=jorgelo
BUG=589318
==========

to

==========
Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

Reason for revert:
Now doesn't use obj/ directory

This simplifies build rules for native tests, and allows us to get rid
of ${target}_deps targets (once recipes are updated).

This change fixes the generated wrapper scripts, which didn't work.

TBR=jorgelo
BUG=589318

Committed: https://crrev.com/66605a610bce190e818ebfc73913a126c025ffb3
Cr-Commit-Position: refs/heads/master@{#384658}
==========

[commit-bot: I haz the power, 2016-04-01 19:20:18]

Patchset 2 (id:??) landed as
https://crrev.com/66605a610bce190e818ebfc73913a126c025ffb3
Cr-Commit-Position: refs/heads/master@{#384658}

[agrieve, 2016-04-04 15:51:57]

A revert of this CL (patchset #2 id:200001) has been created in
https://codereview.chromium.org/1858683002/ by agrieve@chromium.org.

The reason for reverting is: Still breaking bots:

crbug.com/600342.