cc/raster/single_thread_task_graph_runner.cc - Issue 1854723002: cc: Simplify task and its derived classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/raster/single_thread_task_graph_runner.cc

Issue 1854723002: cc: Simplify task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/raster/single_thread_task_graph_runner.cc

diff --git a/cc/raster/single_thread_task_graph_runner.cc b/cc/raster/single_thread_task_graph_runner.cc

index ba879af6cb12d00150cb7346bd1f9ef8950d5645..dde0d4c24f3a2301a11a80e8f6c1a003ab303660 100644

--- a/cc/raster/single_thread_task_graph_runner.cc

+++ b/cc/raster/single_thread_task_graph_runner.cc

@@ -99,7 +99,7 @@ void SingleThreadTaskGraphRunner::WaitForTasksToFinishRunning(

void SingleThreadTaskGraphRunner::CollectCompletedTasks(

NamespaceToken token,

- Task::Vector* completed_tasks) {

+ DependencyTask::Vector* completed_tasks) {

TRACE_EVENT0("cc", "SingleThreadTaskGraphRunner::CollectCompletedTasks");

DCHECK(token.IsValid());

@@ -146,7 +146,7 @@ bool SingleThreadTaskGraphRunner::RunTaskWithLockAcquired() {

const uint16_t category = found->first;

auto prioritized_task = work_queue_.GetNextTaskToRun(category);

- Task* task = prioritized_task.task;

+ DependencyTask* task = prioritized_task.task;

// Call WillRun() before releasing |lock_| and running task.

task->WillRun();