cc/raster/one_copy_tile_task_worker_pool.cc - Issue 1854723002: cc: Simplify task and its derived classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/raster/one_copy_tile_task_worker_pool.cc

Issue 1854723002: cc: Simplify task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/raster/one_copy_tile_task_worker_pool.cc

diff --git a/cc/raster/one_copy_tile_task_worker_pool.cc b/cc/raster/one_copy_tile_task_worker_pool.cc

index 0158752440a8d71f2854b5e75bdf00344f7e07d7..e0b18d4c39dd3bfe7d8375e9e40f14c6de0d8031 100644

--- a/cc/raster/one_copy_tile_task_worker_pool.cc

+++ b/cc/raster/one_copy_tile_task_worker_pool.cc

@@ -272,9 +272,9 @@ void OneCopyTileTaskWorkerPool::CheckForCompletedTasks() {

task_graph_runner_->CollectCompletedTasks(namespace_token_,

&completed_tasks_);

- for (Task::Vector::const_iterator it = completed_tasks_.begin();

+ for (DependencyTask::Vector::const_iterator it = completed_tasks_.begin();

it != completed_tasks_.end(); ++it) {

- TileTask* task = static_cast<TileTask*>(it->get());

+ DependencyTask* task = static_cast<DependencyTask*>(it->get());

task->WillComplete();

task->CompleteOnOriginThread(this);