cc: Simplify task and its derived classes.

cc/raster/dependency_task.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/raster/dependency_task.h"
+
+namespace cc {
+
+DependencyTask::DependencyTask()
+    : will_run_(false),
+      did_run_(false),
+      did_schedule_(false),
+      did_complete_(false) {}
+
+DependencyTask::DependencyTask(DependencyTask::Vector* dependencies)
+    : will_run_(false),
+      did_run_(false),
+      did_schedule_(false),
+      did_complete_(false) {
+  dependencies_.swap(*dependencies);

[ericrk, 2016/04/01 21:34:30]

Rather than having them pass in a non-const * and then us taking memory this
way, let's make the arg by value and then we can just std::move into
dependencies.

[prashant.n, 2016/04/01 23:48:05]

Okay, I'll check apply this modification.

+}
+
+DependencyTask::~DependencyTask() {
+  DCHECK(!will_run_);
+  DCHECK(!did_schedule_);
+  DCHECK(!did_run_ || did_complete_);
+}
+
+void DependencyTask::WillRun() {
+  DCHECK(!will_run_);
+  DCHECK(!did_run_);
+  will_run_ = true;
+}
+
+void DependencyTask::DidRun() {
+  DCHECK(will_run_);
+  will_run_ = false;
+  did_run_ = true;
+}
+
+bool DependencyTask::HasFinishedRunning() const {
+  return did_run_;
+}
+
+void DependencyTask::WillSchedule() {
+  DCHECK(!did_schedule_);
+}
+
+void DependencyTask::DidSchedule() {
+  did_schedule_ = true;
+  did_complete_ = false;
+}
+
+bool DependencyTask::HasBeenScheduled() const {
+  return did_schedule_;
+}
+
+void DependencyTask::WillComplete() {
+  DCHECK(!did_complete_);
+}
+
+void DependencyTask::DidComplete() {
+  DCHECK(did_schedule_);
+  DCHECK(!did_complete_);
+  did_schedule_ = false;
+  did_complete_ = true;
+}
+
+bool DependencyTask::HasCompleted() const {
+  return did_complete_;
+}
+
+}  // namespace cc