src/interpreter/bytecode-generator.cc - Issue 1854713002: Correctly annotate eval origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1854713002: Correctly annotate eval origin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix mips64 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index 619ed89a942807cd3d55f7c5bb450452ea5e2392..1fef7c0bf58cec5ae8251315c8975ecc64dcbae6 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -2462,8 +2462,7 @@ void BytecodeGenerator::VisitCall(Call* expr) {

.MoveRegister(Register::function_closure(), function)

.LoadLiteral(Smi::FromInt(language_mode()))

.StoreAccumulatorInRegister(language)

- .LoadLiteral(

- Smi::FromInt(execution_context()->scope()->start_position()))

+ .LoadLiteral(Smi::FromInt(expr->position()))

.StoreAccumulatorInRegister(position);

// Call ResolvePossiblyDirectEval and modify the callee.