src/compiler/ast-graph-builder.cc - Issue 1854713002: Correctly annotate eval origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1854713002: Correctly annotate eval origin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix mips64 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index a10640f1911b40edc9c519f711b03d9c1aa8cdfd..ab290e3efd2c66d0c989a8666aa5ab592ce3997b 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -2454,7 +2454,7 @@ void AstGraphBuilder::VisitCall(Call* expr) {

// provide a fully resolved callee to patch into the environment.

Node* function = GetFunctionClosure();

Node* language = jsgraph()->Constant(language_mode());

- Node* position = jsgraph()->Constant(current_scope()->start_position());

+ Node* position = jsgraph()->Constant(expr->position());

const Operator* op =

javascript()->CallRuntime(Runtime::kResolvePossiblyDirectEval);

Node* new_callee =

« no previous file with comments | « src/compiler.cc ('k') | src/debug/debug.h » ('j') | src/frames.h » ('J')