Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 18547009: Revert 209420 "Factor out content shell and tests into a standal..." (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 209420 "Factor out content shell and tests into a standal..." > Factor out content shell and tests into a standalone gyp > > This simplifies using components in Content Shell. As components can > depend on the content layer, trying to use a component from Content Shell > results in a cross-reference of gyp files which isn't allowed on Mac. > > TBR=joi,robertshield (trivial one-line renames in gyp files) > > Review URL: https://chromiumcodereview.appspot.com/17366006 TBR=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -106 lines) Patch
M trunk/src/android_webview/android_webview_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/build/all.gyp View 12 chunks +21 lines, -21 lines 0 comments Download
M trunk/src/build/all_android.gyp View 4 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/chrome/chrome.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
MM trunk/src/chrome/chrome_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
MM trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/src/components/components_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
MM trunk/src/content/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
MM trunk/src/content/content.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
MM trunk/src/content/content_shell.gypi View 3 chunks +12 lines, -12 lines 0 comments Download
D trunk/src/content/content_shell_and_tests.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
MM trunk/src/content/content_tests.gypi View 13 chunks +27 lines, -27 lines 0 comments Download
MM trunk/src/ui/views/views.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
7 years, 5 months ago (2013-07-02 20:47:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698