Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1854683003: Issue 26167. Test for indexing a unit which is not attached to a library. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26167. Test for indexing a unit which is not attached to a library. We had the corresponding check wider than tests. So, the problem in the issue does not happen now. But it's still good to have a test. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26167 Committed: https://github.com/dart-lang/sdk/commit/b8fc38e8a83eb8e9c862c77f197736b9363086e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M pkg/analysis_server/test/services/index/index_test.dart View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-04-01 16:36:30 UTC) #1
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-01 16:44:40 UTC) #2
scheglov
4 years, 8 months ago (2016-04-01 16:47:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8fc38e8a83eb8e9c862c77f197736b9363086e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698