Implement PrerenderManager::AddPrerenderForOffline()

chrome/browser/prerender/prerender_origin.h

Index: chrome/browser/prerender/prerender_origin.h
diff --git a/chrome/browser/prerender/prerender_origin.h b/chrome/browser/prerender/prerender_origin.h
index 60e3e0b12f3aa0e23b7d8baed2a5499f99f4ada2..42b9c785654095413ca7ffea1ee2b167981430f0 100644
--- a/chrome/browser/prerender/prerender_origin.h
+++ b/chrome/browser/prerender/prerender_origin.h
@@ -24,12 +24,20 @@ enum Origin {
   ORIGIN_INSTANT = 11,
   ORIGIN_LINK_REL_NEXT = 12,
   ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR = 13,
+  ORIGIN_OFFLINE = 14,
   ORIGIN_MAX,
 };
 
 // Return a human-readable name for |origin|.
 const char* NameFromOrigin(Origin origin);
 
+// Returns whether the origin can be prerendered regardless of the privacy

[pasko, 2016/04/04 17:04:22]

These two functions are implementation detail of PrerenderManager, consumers of
prerender_origin.h must not have visibility into it.

The new use in unittests is not consistent with testing PrerenderManager, and
those EXPECT_TRUE(IsSomething(origin)) for an origin that was defined a few
lines above is something that does not have to be tested.

Please make this logic back private to the PrerenderManager.

[gabadie, 2016/04/04 19:42:51]

Done.

+// settings or cellular network.

[pasko, 2016/04/04 17:04:22]

s/cellular network/network type/

[gabadie, 2016/04/04 19:42:51]

Done.

+bool IsAlwaysPrerenderedOrigin(Origin origin);
+
+// Returns whether the origin should take care of the cellular network.
+bool IsCellularForcedOrigin(Origin origin);

[pasko, 2016/04/04 17:04:22]

Forced prerender on cell networks is not a property of the origin, so the
semantics of this function is confusing.

How about not having these helpful functions? Their names hide important
details, the farther from context they are, the less readable the code is.

[gabadie, 2016/04/04 19:42:51]

Done.

+
 }  // namespace prerender
 
 #endif  // CHROME_BROWSER_PRERENDER_PRERENDER_ORIGIN_H_