chrome/browser/prerender/prerender_constants.h - Issue 1854643002: Implement PrerenderManager::AddPrerenderForOffline()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prerender/prerender_constants.h

Issue 1854643002: Implement PrerenderManager::AddPrerenderForOffline() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses pasko' comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_CONSTANTS_H_

	6 #define CHROME_BROWSER_PRERENDER_PRERENDER_CONSTANTS_H_

	7

	8 namespace prerender {

	9

	10 /* Most of the prerender are used in less than 5 minutes. */
	pasko 2016/04/04 17:04:22 C++ style comments necessary here. C++ style comments necessary here. gabadie 2016/04/04 19:42:50 Done. Show quoted text On 2016/04/04 17:04:22, pasko wrote: > C++ style comments necessary here. Done.
	11 const int kDefaultPrerenderLifeExpectancyMinutes = 5;

	12

	13 /* Offline originated prerenders have an higher life expectancy to have more
	pasko 2016/04/04 17:04:22 And here too - C++ style comments. And here too - C++ style comments. gabadie 2016/04/04 19:42:50 Done. Show quoted text On 2016/04/04 17:04:22, pasko wrote: > And here too - C++ style comments. Done.
	14 * time to fully load web pages from slow network before the web content

	15 * snapshot. */

	16 const int kOfflinePrerenderLifeExpectancyMinutes = 20;

	17

	18 } // namespace prerender

	19

	20 #endif // CHROME_BROWSER_PRERENDER_PRERENDER_CONSTANTS_H_

OLD	NEW