DevTools: Introduce Target class which holds connection & models

Source/devtools/front_end/ConsoleModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
+ * @param {!WebInspector.Target} target
  */
-WebInspector.ConsoleModel = function()
+WebInspector.ConsoleModel = function(target)
 {
-    this._agent = ConsoleAgent;
+    this._agent = target.connection.agent("Console");

[aandrey, 2014/03/04 10:05:16]

this should be typed for the js compiler, so either cast, or (better)
encapsulate the "connection" inside target and expose explicit:
target.consoleAgent(), target.pageAgent(),... that will return a proper @return
types.

[sergeyv, 2014/03/04 12:42:37]

Partially done. I encapsulated connection. But, unfortunately, our generator
does not create type ConsoleAgent, but instance of it, thus our compiler does
not understand /** @type {!ConsoleAgent} */

I will handle this issue in a separate patch. 

     this.messages = [];
     this.warnings = 0;
     this.errors = 0;
     this._interruptRepeatCount = false;
-    InspectorBackend.registerConsoleDispatcher(new WebInspector.ConsoleDispatcher(this));
+    target.connection.registerDispatcher("Console", new WebInspector.ConsoleDispatcher(this));

[aandrey, 2014/03/04 10:05:16]

encapsulate connection?

[sergeyv, 2014/03/04 12:42:37]

Done.

 }
 
 WebInspector.ConsoleModel.Events = {
     ConsoleCleared: "console-cleared",
     MessageAdded: "console-message-added",
     RepeatCountUpdated: "repeat-count-updated"
 }
 
 WebInspector.ConsoleModel.prototype = {
     enableAgent: function()
@@ skipping 275 matching lines @@
     {
         if (!WebInspector.settings.preserveConsoleLog.get())
             this._console.clearMessages();
     }
 }
 
 /**
  * @type {!WebInspector.ConsoleModel}
  */
 WebInspector.console;