Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

Issue 18546003: Fix tests to avoid page scale reset when setting page scale. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove internals.setPageScaleFactor, rename eventSender.scalePageBy. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 bindMethod("gestureScrollUpdate", &EventSender::gestureScrollUpdate); 294 bindMethod("gestureScrollUpdate", &EventSender::gestureScrollUpdate);
295 bindMethod("gestureScrollUpdateWithoutPropagation", &EventSender::gestureScr ollUpdateWithoutPropagation); 295 bindMethod("gestureScrollUpdateWithoutPropagation", &EventSender::gestureScr ollUpdateWithoutPropagation);
296 bindMethod("gestureTap", &EventSender::gestureTap); 296 bindMethod("gestureTap", &EventSender::gestureTap);
297 bindMethod("gestureTapDown", &EventSender::gestureTapDown); 297 bindMethod("gestureTapDown", &EventSender::gestureTapDown);
298 bindMethod("gestureTapCancel", &EventSender::gestureTapCancel); 298 bindMethod("gestureTapCancel", &EventSender::gestureTapCancel);
299 bindMethod("gestureLongPress", &EventSender::gestureLongPress); 299 bindMethod("gestureLongPress", &EventSender::gestureLongPress);
300 bindMethod("gestureLongTap", &EventSender::gestureLongTap); 300 bindMethod("gestureLongTap", &EventSender::gestureLongTap);
301 bindMethod("gestureTwoFingerTap", &EventSender::gestureTwoFingerTap); 301 bindMethod("gestureTwoFingerTap", &EventSender::gestureTwoFingerTap);
302 bindMethod("zoomPageIn", &EventSender::zoomPageIn); 302 bindMethod("zoomPageIn", &EventSender::zoomPageIn);
303 bindMethod("zoomPageOut", &EventSender::zoomPageOut); 303 bindMethod("zoomPageOut", &EventSender::zoomPageOut);
304 bindMethod("scalePageBy", &EventSender::scalePageBy); 304 bindMethod("setInitialPageScaleOverride", &EventSender::setInitialPageScaleO verride);
305 bindMethod("setPageScaleFactor", &EventSender::setPageScaleFactor);
305 306
306 bindProperty("forceLayoutOnEvents", &forceLayoutOnEvents); 307 bindProperty("forceLayoutOnEvents", &forceLayoutOnEvents);
307 308
308 // When set to true (the default value), we batch mouse move and mouse up 309 // When set to true (the default value), we batch mouse move and mouse up
309 // events so we can simulate drag & drop. 310 // events so we can simulate drag & drop.
310 bindProperty("dragMode", &dragMode); 311 bindProperty("dragMode", &dragMode);
311 #ifdef WIN32 312 #ifdef WIN32
312 bindProperty("WM_KEYDOWN", &wmKeyDown); 313 bindProperty("WM_KEYDOWN", &wmKeyDown);
313 bindProperty("WM_KEYUP", &wmKeyUp); 314 bindProperty("WM_KEYUP", &wmKeyUp);
314 bindProperty("WM_CHAR", &wmChar); 315 bindProperty("WM_CHAR", &wmChar);
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 webview()->setZoomLevel(false, webview()->zoomLevel() + 1); 771 webview()->setZoomLevel(false, webview()->zoomLevel() + 1);
771 result->setNull(); 772 result->setNull();
772 } 773 }
773 774
774 void EventSender::zoomPageOut(const CppArgumentList&, CppVariant* result) 775 void EventSender::zoomPageOut(const CppArgumentList&, CppVariant* result)
775 { 776 {
776 webview()->setZoomLevel(false, webview()->zoomLevel() - 1); 777 webview()->setZoomLevel(false, webview()->zoomLevel() - 1);
777 result->setNull(); 778 result->setNull();
778 } 779 }
779 780
780 void EventSender::scalePageBy(const CppArgumentList& arguments, CppVariant* resu lt) 781 void EventSender::setInitialPageScaleOverride(const CppArgumentList& arguments, CppVariant* result)
782 {
783 if (arguments.size() != 1 || !arguments[0].isNumber())
784 return;
785
786 float pageScaleOverride = static_cast<float>(arguments[0].toDouble());
787 webview()->setInitialPageScaleOverride(pageScaleOverride);
788 result->setNull();
789 }
790
791 void EventSender::setPageScaleFactor(const CppArgumentList& arguments, CppVarian t* result)
781 { 792 {
782 if (arguments.size() < 3 || !arguments[0].isNumber() || !arguments[1].isNumb er() || !arguments[2].isNumber()) 793 if (arguments.size() < 3 || !arguments[0].isNumber() || !arguments[1].isNumb er() || !arguments[2].isNumber())
783 return; 794 return;
784 795
785 float scaleFactor = static_cast<float>(arguments[0].toDouble()); 796 float scaleFactor = static_cast<float>(arguments[0].toDouble());
786 int x = arguments[1].toInt32(); 797 int x = arguments[1].toInt32();
787 int y = arguments[2].toInt32(); 798 int y = arguments[2].toInt32();
788 webview()->setPageScaleFactor(scaleFactor, WebPoint(x, y)); 799 webview()->setPageScaleFactor(scaleFactor, WebPoint(x, y));
789 result->setNull(); 800 result->setNull();
790 } 801 }
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
1374 { 1385 {
1375 result->setNull(); 1386 result->setNull();
1376 } 1387 }
1377 1388
1378 void EventSender::clearKillRing(const CppArgumentList&, CppVariant* result) 1389 void EventSender::clearKillRing(const CppArgumentList&, CppVariant* result)
1379 { 1390 {
1380 result->setNull(); 1391 result->setNull();
1381 } 1392 }
1382 1393
1383 } 1394 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698