Make leadingWhitespacePosition() to respect "white-space" CSS property

Make leadingWhitespacePosition() to respect "white-space" CSS property

This patch makes |leadingWhitespacePosition()|, which returns collapsible
whitespace position, to return null |Position| when a previous position of
specified position is in a element which preserves whitespaces, e.g.
"white-space:pre", "white-space:pre-word", etc.

Before this patch, |leadingWhitespacePosition()| uses only
|isCollapsibleWhitespace(UChar)| to check collapsible whitespace without
considering "white-space" CSS property.

BUG=598665
TESET=run_layout_test editing/execCommand/insert_paragraph/insert_paragraph_pre_crash.html

Committed: https://crrev.com/2063467918ab92fe1969fbd9a1b37f29c4661cc6
Cr-Commit-Position: refs/heads/master@{#384509}

[yosin_UTC9, 2016-04-01 04:21:24]

Description was changed from

==========
2016-04-01T13:19:03

BUG=598665
==========

to

==========
Make leadingWhitespacePosition() to respect "white-space" CSS property 

This patch makes |leadingWhitespacePosition()|, which returns collapsible
whitespace position, to return null |Position| when a previous position of
specified position is in a element which preserves whitespaces, e.g.
"white-space:pre", "white-space:pre-word", etc.

Before this patch, |leadingWhitespacePosition()| uses only
|isCollapsibleWhitespace(UChar)| to check collapsible whitespace without
considering "white-space" CSS property.

BUG=598665
TESET=run_layout_test
editing/execCommand/insert_paragraph/insert_paragraph_pre_crash.html
==========

[yosin_UTC9, 2016-04-01 04:21:25]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-04-01 04:21:39]

PTAL

[yoichio, 2016-04-01 05:10:05]

https://codereview.chromium.org/1854583003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1854583003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:1409: if
(!isSpaceOrNewline(previousCharacter) && previousCharacter !=
noBreakSpaceCharacter)
This check works whether option is?

[yosin_UTC9, 2016-04-01 05:53:37]

PTAL

The code change is only checking "white-space" CSS property now.

https://codereview.chromium.org/1854583003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1854583003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:1409: if
(!isSpaceOrNewline(previousCharacter) && previousCharacter !=
noBreakSpaceCharacter)
On 2016/04/01 at 05:10:05, yoichio wrote:
> This check works whether option is?

Go tit. Revert this change.

[yoichio, 2016-04-01 06:14:16]

On 2016/04/01 05:53:37, Yosi_UTC9 wrote:
> PTAL
> 
> The code change is only checking "white-space" CSS property now.
> 
>
https://codereview.chromium.org/1854583003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):
> 
>
https://codereview.chromium.org/1854583003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/EditingUtilities.cpp:1409: if
> (!isSpaceOrNewline(previousCharacter) && previousCharacter !=
> noBreakSpaceCharacter)
> On 2016/04/01 at 05:10:05, yoichio wrote:
> > This check works whether option is?
> 
> Go tit. Revert this change.
lgtm

[yosin_UTC9, 2016-04-01 06:39:20]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:39:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854583003/20001

[commit-bot: I haz the power, 2016-04-01 07:30:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 07:31:49]

Description was changed from

==========
Make leadingWhitespacePosition() to respect "white-space" CSS property 

This patch makes |leadingWhitespacePosition()|, which returns collapsible
whitespace position, to return null |Position| when a previous position of
specified position is in a element which preserves whitespaces, e.g.
"white-space:pre", "white-space:pre-word", etc.

Before this patch, |leadingWhitespacePosition()| uses only
|isCollapsibleWhitespace(UChar)| to check collapsible whitespace without
considering "white-space" CSS property.

BUG=598665
TESET=run_layout_test
editing/execCommand/insert_paragraph/insert_paragraph_pre_crash.html
==========

to

==========
Make leadingWhitespacePosition() to respect "white-space" CSS property

This patch makes |leadingWhitespacePosition()|, which returns collapsible
whitespace position, to return null |Position| when a previous position of
specified position is in a element which preserves whitespaces, e.g.
"white-space:pre", "white-space:pre-word", etc.

Before this patch, |leadingWhitespacePosition()| uses only
|isCollapsibleWhitespace(UChar)| to check collapsible whitespace without
considering "white-space" CSS property.

BUG=598665
TESET=run_layout_test
editing/execCommand/insert_paragraph/insert_paragraph_pre_crash.html

Committed: https://crrev.com/2063467918ab92fe1969fbd9a1b37f29c4661cc6
Cr-Commit-Position: refs/heads/master@{#384509}
==========

[commit-bot: I haz the power, 2016-04-01 07:31:49]

Patchset 2 (id:??) landed as
https://crrev.com/2063467918ab92fe1969fbd9a1b37f29c4661cc6
Cr-Commit-Position: refs/heads/master@{#384509}