common/tsmon/context.go - Issue 1854583002: Migrate tsmon protos to proto3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/tsmon/context.go

Issue 1854583002: Migrate tsmon protos to proto3 (Closed) Base URL: git@github.com:luci/luci-go.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/tsmon/context.go

diff --git a/common/tsmon/context.go b/common/tsmon/context.go

index 55a1b50fd0a0712d7afeda1b30f918c21c62087c..08fd4fbedadfda7bfa4194c736b13b3fb84f1e2c 100644

--- a/common/tsmon/context.go

+++ b/common/tsmon/context.go

@@ -7,7 +7,6 @@ package tsmon

import (

"sync"

- "github.com/golang/protobuf/proto"

"golang.org/x/net/context"

"github.com/luci/luci-go/common/tsmon/monitor"

@@ -67,7 +66,7 @@ func WithFakes(c context.Context) (context.Context, *store.Fake, *monitor.Fake)

// WithDummyInMemory returns a new context holding a new State with a new in-

// memory store and a fake monitor.

func WithDummyInMemory(c context.Context) (context.Context, *monitor.Fake) {

- s := store.NewInMemory(&target.Task{ServiceName: proto.String("")})

+ s := store.NewInMemory(&target.Task{})

m := &monitor.Fake{}

return WithState(c, &State{

S: s,

« no previous file with comments | « appengine/tsmon/standardmetrics_test.go ('k') | common/tsmon/field/field.go » ('j') | no next file with comments »