content/browser/android/download_controller_android_impl.h - Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/download_controller_android_impl.h

Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | content/browser/android/download_controller_android_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/download_controller_android_impl.h

diff --git a/content/browser/android/download_controller_android_impl.h b/content/browser/android/download_controller_android_impl.h

index 78d6544f942536cb1fddb397e84ce4be81f4889a..157f306300dbf89d54eb9aea94c47ef4c61e7ece 100644

--- a/content/browser/android/download_controller_android_impl.h

+++ b/content/browser/android/download_controller_android_impl.h

@@ -95,7 +95,8 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid {

// DownloadControllerAndroid implementation.

void CreateGETDownload(int render_process_id,

int render_view_id,

- int request_id) override;

+ int request_id,

+ bool must_download) override;

void OnDownloadStarted(DownloadItem* download_item) override;

void StartContextMenuDownload(const ContextMenuParams& params,

WebContents* web_contents,

@@ -126,9 +127,11 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid {

const DownloadInfoAndroid& info);

void StartAndroidDownload(int render_process_id,

int render_view_id,

+ bool must_download,

const DownloadInfoAndroid& info);

void StartAndroidDownloadInternal(int render_process_id,

int render_view_id,

+ bool must_download,

const DownloadInfoAndroid& info,

bool allowed);