chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java - Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java ('k') | chrome/browser/android/download/mock_download_controller_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

index 4c3927b20eb217edfa82f679c7f0a9e3a37f7b44..b1e59ab5c313e16f27efa86932501ae080c9712f 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

@@ -617,19 +617,5 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {

.setMimeType("application/pdf")

.setHasUserGesture(false)

.build()));

- // But should not open any PDFs with Content-Disposition: attachment.

- assertFalse(

- DownloadManagerService.shouldOpenAfterDownload(new DownloadInfo.Builder()

- .setContentDisposition("attachment")

- .setMimeType("application/pdf")

- .setHasUserGesture(true)

- .build()));

- assertFalse(

- DownloadManagerService.shouldOpenAfterDownload(new DownloadInfo.Builder()

- .setContentDisposition("attachment; filename=test.pdf")

- .setMimeType("application/pdf")

- .setHasUserGesture(true)

- .build()));

}