Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1854503002: Add meta charset tag to unlabelled utf-8 files (Closed)

Created:
4 years, 8 months ago by jungshik at Google
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, pdr., dpranke
CC:
chromium-reviews, apavlov+blink_chromium.org, Jinsuk Kim, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, jam, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-w3ctests_chromium.org, yuzo+watch_chromium.org, dmazzoni, lushnikov+blink_chromium.org, tfarina, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, jshin+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add meta charset tag to unlabelled utf-8 files There are 200+ UTF-8 files without a charset=utf-8 specified. They're are labelled with meta charset except for the following two groups. * Some are intentionally unlabelled or mislabelled. They're left alone. (e.g. fast/encoding/charset-{utf16,unicode}.html ) * files in ietestcenter/, css2.1/20110323 and imported/web-platform-tests/IndexedDB unless non-ASCII characters show up in actual contents (i.e. other than meta author, comments, etc). In most cases, explicitly specifying charset=utf-8 do not affect the test results because non-ASCII characters are in the reviewer's name (W3C upstream) in "<meta reviewer>". In other cases, tests are reference tests so that adding meta charset=utf-8 to both test and expected html files works without any further update. For a few tests (non-reference test) whose results are affected, expected.txt files are updated if it's text-only and platform-independent. Finally, four tests are marked with 'NeedsRebaseline' because they need platform-dependent pixel results. BUG=597517 TEST=Layout tests Committed: https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a Cr-Commit-Position: refs/heads/master@{#384801}

Patch Set 1 #

Patch Set 2 : TestExpectation updated. non-utf-8 file changes removed #

Patch Set 3 : expectation update #

Patch Set 4 : add a few more; drop chanegs in css2.1 with non-ASCII only in meta #

Patch Set 5 : add back U+E47E to svg text crash test #

Patch Set 6 : drop two more files unaffected by utf-8 label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/floats-001.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/floats-001-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/floats-149.htm View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/floats-149-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/replaced-intrinsic-003.htm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/word-spacing-characters-003.htm View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css2.1/20110323/word-spacing-characters-003-expected.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/extend-byline-withfloat.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/bidi-002.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/bidi-009a.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-generated-content/quotes-lang-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-001.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-offset-001.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/case-sensitive-003.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/case-sensitive-004.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/content-property-quote-types.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/heightless-list-item.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-on-culled-inline-with-pseudo.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-attribute-parsing-03.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-attribute-parsing-03-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/webidl-attribute-getter-setter-lengths.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/parser/smart-quotes-in-tag.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-block-vrl-006.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-block-vrl-006-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vlr-006.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vlr-006-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vrl-006.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vrl-006-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-001.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-001-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-002.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-002-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-003.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-003-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-004-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-001.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-001-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-002.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-002-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-003.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-003-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-004-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/IndexedDB/idbcursor-direction-index-keyrange.htm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/IndexedDB/idbcursor-direction-objectstore-keyrange.htm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing-model-storage.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/plugins/plugin-remove-subframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/plugins/plugin-remove-subframe-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/select-text-svgfont.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/text-layout-crash.html View 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/text-layout-crash-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
jungshik at Google
Dirk: can you take a look? pdr@: Can you confirm that svg/text/text-layout-crash.html does not need ...
4 years, 8 months ago (2016-04-01 17:44:31 UTC) #4
jungshik at Google
Ick, css2.1/20110323/ has a bunch of files whose names end with 'htm' while their expectation ...
4 years, 8 months ago (2016-04-01 17:54:11 UTC) #7
Dirk Pranke
lgtm.
4 years, 8 months ago (2016-04-01 20:23:21 UTC) #10
pdr.
On 2016/04/01 at 17:44:31, jshin wrote: > Dirk: can you take a look? > > ...
4 years, 8 months ago (2016-04-01 23:34:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854503002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854503002/100001
4 years, 8 months ago (2016-04-02 08:10:26 UTC) #19
jungshik at Google
On 2016/04/01 23:34:46, pdr wrote: > On 2016/04/01 at 17:44:31, jshin wrote: > > Dirk: ...
4 years, 8 months ago (2016-04-02 08:10:40 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-02 09:20:20 UTC) #22
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a Cr-Commit-Position: refs/heads/master@{#384801}
4 years, 8 months ago (2016-04-02 09:21:41 UTC) #24
tkent
Updating LayoutTests/imported will be reverted by the next import. You need to update tests in ...
4 years, 8 months ago (2016-04-03 18:06:32 UTC) #25
jungshik at Google
On 2016/04/03 18:06:32, unavailable_until_Apr_7 wrote: > Updating LayoutTests/imported will be reverted by the next import. ...
4 years, 8 months ago (2016-04-04 18:53:17 UTC) #26
jungshik at Google
4 years, 8 months ago (2016-04-04 19:26:53 UTC) #27
Message was sent while issue was closed.
On 2016/04/04 18:53:17, jshin (jungshik at google) wrote:
> On 2016/04/03 18:06:32, unavailable_until_Apr_7 wrote:
> > Updating LayoutTests/imported will be reverted by the next import.  You need
> to
> > update tests in the upstream.
> 
> Thanks for the reminder. I've filed a bug against the upstream (for css3):
> https://github.com/w3c/csswg-test/issues/1071
> 
> I'll do the same for IndexDB (web-platform tests).

For web-platform-tests: It's
https://github.com/w3c/web-platform-tests/issues/2747

Powered by Google App Engine
This is Rietveld 408576698