Remove WebUSB descriptor data from device.mojom.

Remove WebUSB descriptor data from device.mojom.

This data is no longer used by clients of //device/usb's Mojo interface.

BUG=None

Committed: https://crrev.com/f1cce2f8bcf4bcb5051949c917197faa6d83cdf4
Cr-Commit-Position: refs/heads/master@{#386544}

[Reilly Grant (use Gerrit), 2016-03-31 22:23:58]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-03-31 22:23:59]

Please take a look.

[juncai, 2016-04-01 17:05:24]

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/usb_choo...
File chrome/browser/usb/usb_chooser_context.h (right):

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/usb_choo...
chrome/browser/usb/usb_chooser_context.h:50: scoped_refptr<const
device::UsbDevice> device_info);
change device_info parameter name to device since it is not DeviceInfo any more.

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/web_usb_...
File chrome/browser/usb/web_usb_permission_provider.cc (right):

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/web_usb_...
chrome/browser/usb/web_usb_permission_provider.cc:35: if
(ContainsValue(set->origins, origin))
add header:
#include "base/stl_util.h"
for using ContainsValue() function.

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
File device/usb/mojo/mock_permission_provider.h (right):

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:25: bool(scoped_refptr<const
UsbDevice> device_info));
change device_info parameter name to device.

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:28: scoped_refptr<const UsbDevice>
device_info));
ditto

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:32: scoped_refptr<const UsbDevice>
device_info));
ditto

[Reilly Grant (use Gerrit), 2016-04-01 21:56:34]

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/usb_choo...
File chrome/browser/usb/usb_chooser_context.h (right):

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/usb_choo...
chrome/browser/usb/usb_chooser_context.h:50: scoped_refptr<const
device::UsbDevice> device_info);
On 2016/04/01 at 17:05:24, juncai wrote:
> change device_info parameter name to device since it is not DeviceInfo any
more.

Fixed.

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/web_usb_...
File chrome/browser/usb/web_usb_permission_provider.cc (right):

https://codereview.chromium.org/1854483002/diff/1/chrome/browser/usb/web_usb_...
chrome/browser/usb/web_usb_permission_provider.cc:35: if
(ContainsValue(set->origins, origin))
On 2016/04/01 at 17:05:24, juncai wrote:
> add header:
> #include "base/stl_util.h"
> for using ContainsValue() function.

Done.

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
File device/usb/mojo/mock_permission_provider.h (right):

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:25: bool(scoped_refptr<const
UsbDevice> device_info));
On 2016/04/01 at 17:05:24, juncai wrote:
> change device_info parameter name to device.

Done.

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:28: scoped_refptr<const UsbDevice>
device_info));
On 2016/04/01 at 17:05:24, juncai wrote:
> ditto

Done.

https://codereview.chromium.org/1854483002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:32: scoped_refptr<const UsbDevice>
device_info));
On 2016/04/01 at 17:05:24, juncai wrote:
> ditto

Done.

[juncai, 2016-04-02 00:17:33]

LGTM.

[Reilly Grant (use Gerrit), 2016-04-04 18:57:11]

reillyg@chromium.org changed reviewers:
+ markusheintz@chromium.org

[Reilly Grant (use Gerrit), 2016-04-04 18:57:11]

markusheintz@chromium.org, please take a look at changes in //chrome/browser/ui.

[Reilly Grant (use Gerrit), 2016-04-07 01:01:08]

reillyg@chromium.org changed reviewers:
+ palmer@chromium.org

[Reilly Grant (use Gerrit), 2016-04-07 01:01:08]

palmer@, please review //chrome/browser/ui.

[Reilly Grant (use Gerrit), 2016-04-11 18:10:49]

Friendly ping for a //chrome/browser/ui review.

[palmer, 2016-04-11 20:33:47]

I'm not sure what I'm seeing. Was any of the information you are removing ever
used in security decisions or in security UX? I wonder because I see fields
named |origins|...

[Reilly Grant (use Gerrit), 2016-04-11 21:01:26]

On 2016/04/11 at 20:33:47, palmer wrote:
> I'm not sure what I'm seeing. Was any of the information you are removing ever
used in security decisions or in security UX? I wonder because I see fields
named |origins|...

It was sent from one part of the browser process to another as part of this
Mojo-defined struct to make a security decision. Since there's little point in
using Mojo when not communicating cross-process I've removed that extra layer.
The reason it was ever done via Mojo is that at some point it was considered
that the USB service implementation could live in a separate process from the
browser and so would need a way for the browser to control security policy.

[palmer, 2016-04-11 21:06:15]

OK, thanks. LGTM.

[Reilly Grant (use Gerrit), 2016-04-11 21:13:51]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-11 21:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/1854483002/#ps60001
(title: "Remove InterfaceInfo::first_interface as well.")

[commit-bot: I haz the power, 2016-04-11 21:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854483002/60001

[commit-bot: I haz the power, 2016-04-11 21:18:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 21:18:55]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Reilly Grant (use Gerrit), 2016-04-11 22:28:53]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-11 22:28:53]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/1854483002/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-04-11 22:29:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854483002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854483002/80001

[commit-bot: I haz the power, 2016-04-12 01:33:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-12 01:35:56]

Description was changed from

==========
Remove WebUSB descriptor data from device.mojom.

This data is no longer used by clients of //device/usb's Mojo interface.

BUG=None
==========

to

==========
Remove WebUSB descriptor data from device.mojom.

This data is no longer used by clients of //device/usb's Mojo interface.

BUG=None

Committed: https://crrev.com/f1cce2f8bcf4bcb5051949c917197faa6d83cdf4
Cr-Commit-Position: refs/heads/master@{#386544}
==========

[commit-bot: I haz the power, 2016-04-12 01:35:57]

Patchset 5 (id:??) landed as
https://crrev.com/f1cce2f8bcf4bcb5051949c917197faa6d83cdf4
Cr-Commit-Position: refs/heads/master@{#386544}