Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1854463002: arc: Fix issue when Arc OptIn is not started on fresh devices. (Closed)

Created:
4 years, 8 months ago by khmel
Modified:
4 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix issue when Arc OptIn is not started on fresh devices. BUG=599668 TEST=Manually tested on devices. Arc OptIn started on fresh devices. Committed: https://crrev.com/fc1fa4a9665f8720776d9e790751d8feddb72752 Cr-Commit-Position: refs/heads/master@{#384431}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 2 chunks +9 lines, -5 lines 4 comments Download

Messages

Total messages: 10 (3 generated)
khmel
https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc File chrome/browser/chromeos/arc/arc_auth_service.cc (right): https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc#newcode231 chrome/browser/chromeos/arc/arc_auth_service.cc:231: PrefServiceSyncableFromProfile(profile_)->AddObserver(this); In one of the recent CLs I changed ...
4 years, 8 months ago (2016-03-31 22:19:21 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc File chrome/browser/chromeos/arc/arc_auth_service.cc (right): https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc#newcode251 chrome/browser/chromeos/arc/arc_auth_service.cc:251: if (!disable_ui_for_testing && profile_->IsNewProfile() && nit: profile_->IsNewProfile() might ...
4 years, 8 months ago (2016-03-31 22:32:44 UTC) #3
khmel
https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc File chrome/browser/chromeos/arc/arc_auth_service.cc (right): https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc#newcode251 chrome/browser/chromeos/arc/arc_auth_service.cc:251: if (!disable_ui_for_testing && profile_->IsNewProfile() && On 2016/03/31 22:32:44, xiyuan ...
4 years, 8 months ago (2016-03-31 22:47:34 UTC) #4
xiyuan
https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc File chrome/browser/chromeos/arc/arc_auth_service.cc (right): https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc/arc_auth_service.cc#newcode251 chrome/browser/chromeos/arc/arc_auth_service.cc:251: if (!disable_ui_for_testing && profile_->IsNewProfile() && On 2016/03/31 22:47:34, khmel ...
4 years, 8 months ago (2016-03-31 22:50:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854463002/1
4 years, 8 months ago (2016-03-31 22:52:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 23:33:17 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 23:34:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc1fa4a9665f8720776d9e790751d8feddb72752
Cr-Commit-Position: refs/heads/master@{#384431}

Powered by Google App Engine
This is Rietveld 408576698